Merged
Conversation
…e list cmd, and reorganize utils - move activity command logic into src/commands/activity.rs for improved modularity - remove activity_with_log.rs, introduce activity_log.rs with a focused log model - refactor list and log printing logic for consistency; improve JSON and table output - enhance CLI: add better period/date filters, clarify subcommands and argument validation - split utils.rs into utils/date.rs, add utils/mod.rs and placeholder utils/common.rs - add tags to PrintableActivity, improve models and row output - simplify main.rs by delegating logic to command modules - **BREAKING CHANGE:** activity listing model and CLI argument structure have changed
- add integration tests covering activity flow, error scenarios, and CLI output validation using assert_cmd, predicates, and tempfile. - add unit tests for formatting, parsing, and edge case handling in models and utility modules. - fix command argument handling and config injection in tests to use `BOAT_CONFIG` env var. - update error message assertions for compatibility with current clap output. - ensure robust duration formatting and corresponding expectation in tests.
coko7
force-pushed
the
refactor-and-tests
branch
from
1cc1c52 to
26e5a92
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.