fix: handle empty block_number gracefully#10
Merged
coko7 merged 2 commits intocoko7:mainfrom Mar 24, 2026
Merged
Conversation
Change block_number from required (i32) to optional (Option<i32>) to handle cases where the source website has missing data. This follows the same pattern used for other optional numeric fields (cost, power, counter) in the codebase. Fixes coko7#9 Made-with: Cursor
Owner
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
block_numberfield from required (i32) to optional (Option<i32>) to handle missing data on the source websitefetch_block_numberto returnNoneinstead of failing when the field is empty or contains no digitscost,power,counter)Test plan
cargo checkpasses"block_number": nullin the JSON output instead of causing the entire scrape to failFixes #9
Made with Cursor