Use pallet-patcher to make Cargo prioritize workspace and system crates#69
Draft
Blast545 wants to merge 6 commits intocolcon:mainfrom
Draft
Use pallet-patcher to make Cargo prioritize workspace and system crates#69Blast545 wants to merge 6 commits intocolcon:mainfrom
Blast545 wants to merge 6 commits intocolcon:mainfrom
Conversation
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
Contributor
|
@Blast545 when you have a moment, can you update the description with what this PR does, the rationale for these changes, etc? Thanks |
Author
|
Sure! I am adding a functional workflow to show how it works, that's why I opened it as a draft. Give me like 30' |
Blast545
force-pushed
the
main
branch
6 times, most recently
from
c75b99f to
446c81d
Compare
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
Blast545
force-pushed
the
main
branch
4 times, most recently
from
b6bf6f3 to
d4b83d9
Compare
Blast545
force-pushed
the
main
branch
2 times, most recently
from
a2bc51e to
51adbff
Compare
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to use pallet-patcher as an additional dependency added to colcon to help Cargo resolve where to get packages from. See some discussions starting here: #67 (comment)
This PR is rather simple, because most of the heavy lifting is done in pallet-patcher. That work is still being reviewed, so I will leave this PR as a draft for now.
pallet-patcher will be run in each colcon build command, such that it checks for a list of search_paths for dependencies.