Skip to content

invoke unittest directly instead of through the setup.py file #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 30, 2020
Merged

invoke unittest directly instead of through the setup.py file #299

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 17 additions & 11 deletions colcon_core/task/python/test/setuppy_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,34 +10,40 @@


class SetuppyPythonTestingStep(PythonTestingStepExtensionPoint):
"""Use `setup.py test` to test packages."""
"""Use `unittest` to test packages."""

def __init__(self): # noqa: D107
super().__init__()
satisfies_version(
PythonTestingStepExtensionPoint.EXTENSION_POINT_VERSION, '^1.0')

def add_arguments(self, *, parser): # noqa: D102
parser.add_argument(
'--unittest-args',
nargs='*', metavar='*', type=str.lstrip,
help='Pass arguments to Python unittests. '
'Arguments matching other options must be prefixed by a space,\n'
'e.g. --unittest-args " --help"')

def match(self, context, env, setup_py_data): # noqa: D102
return True

async def step(self, context, env, setup_py_data): # noqa: D102
if context.args.retest_until_fail:
logger.warning(
"Ignored '--retest-until-fail' for package "
"'{context.pkg.name}' since 'setup.py test' does not support "
'the usage'.format_map(locals()))
"'{context.pkg.name}' since 'unittest' does not support the "
'usage'.format_map(locals()))

if context.args.retest_until_pass:
logger.warning(
"Ignored '--retest-until-pass' for package "
"'{context.pkg.name}' since 'setup.py test' does not support "
'the usage'.format_map(locals()))

cmd = [
executable,
'setup.py', 'test',
'egg_info', '--egg-base', context.args.build_base,
]
"'{context.pkg.name}' since 'unittest' does not support the "
'usage'.format_map(locals()))

cmd = [executable, '-m', 'unittest', '-v']
if context.args.unittest_args is not None:
cmd += context.args.unittest_args
rc = await check_call(context, cmd, cwd=context.args.path, env=env)
if rc and rc.returncode:
return rc.returncode