Use win32 timer to destroy notification window #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A simple sleep doesn't allow win32gui to process any other notifications or callbacks. If we destroy the window using a win32 timer and process messages instead of sleeping, we can react to other user input (future work).
cottsay
force-pushed
the
cottsay/win-message-pump
branch
from
9b57562 to
c3e87ec
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #77 +/- ##
==========================================
- Coverage 19.25% 18.99% -0.27%
==========================================
Files 9 9
Lines 431 437 +6
Branches 65 66 +1
==========================================
Hits 83 83
- Misses 335 341 +6
Partials 13 13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Crola1702
reviewed
Nov 10, 2025
Crola1702
left a comment
Crola1702
left a comment
There was a problem hiding this comment.
I don't have much context on this one, but... LGTM (Gray check)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple sleep doesn't allow win32gui to process any other notifications or callbacks. If we destroy the window using a win32 timer and process messages instead of sleeping, we can react to other user input (future work).