Skip to content

Commit 94588ea

Browse files
committed
chore(CI): Remove ColdBox 5 from CI matrix
This was done in the code and README for v2.0.0 but not in the CI configuration. That means the major change was already done in practice, just not in CI.
1 parent 49a68ba commit 94588ea

File tree

6 files changed

+8
-5
lines changed

6 files changed

+8
-5
lines changed

.github/workflows/cron.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ jobs:
1111
strategy:
1212
matrix:
1313
cfengine: ["lucee@5", "lucee@be", "adobe@2018", "adobe@be"]
14-
coldbox: ["coldbox@5", "coldbox@6", "coldbox@be"]
14+
coldbox: ["coldbox@6", "coldbox@be"]
1515
javaVersion: ["openjdk8", "openjdk11"]
1616
services:
1717
postgres:

.github/workflows/pr.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ jobs:
2020
fail-fast: false
2121
matrix:
2222
cfengine: ["lucee@5", "adobe@2018"]
23-
coldbox: ["coldbox@5", "coldbox@6"]
23+
coldbox: ["coldbox@6"]
2424
services:
2525
postgres:
2626
image: postgres:12

.github/workflows/prerelease.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
fail-fast: true
1515
matrix:
1616
cfengine: ["lucee@5", "adobe@2018"]
17-
coldbox: ["coldbox@5", "coldbox@6"]
17+
coldbox: ["coldbox@6"]
1818
services:
1919
postgres:
2020
image: postgres:12

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ jobs:
1515
fail-fast: true
1616
matrix:
1717
cfengine: ["lucee@5", "adobe@2018"]
18-
coldbox: ["coldbox@5", "coldbox@6"]
18+
coldbox: ["coldbox@6"]
1919
services:
2020
postgres:
2121
image: postgres:12

box.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,8 @@
3939
"qb":"modules/qb/",
4040
"testbox":"testbox/",
4141
"coldbox":"tests/resources/app/coldbox/",
42-
"mockdatacfc":"modules/mockdatacfc/"
42+
"mockdatacfc":"modules/mockdatacfc/",
43+
"orgpostgresqljdbc424214lex":"orgpostgresqljdbc424214lex/"
4344
},
4445
"devDependencies":{
4546
"testbox":"^4",

models/MigrationService.cfc

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,8 @@ component accessors="true" {
3333
} )
3434
.each( function( key ) {
3535
if ( isSimpleValue( args[ key ] ) ) {
36+
// For some reason Lucee only picks up the `invoke` and ACF only picks up the scope assignment.
37+
invoke( this, "set" & key, { "#key#" = args[ key ] } );
3638
variables[ key ] = args[ key ];
3739
} else if ( key == "properties" ) {
3840
variables.managerProperties = args[ key ];

0 commit comments

Comments
 (0)