Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a test case to verify that zshy correctly handles packages with only a bin configuration (without exports in the zshy config), ensuring that existing exports fields in package.json are preserved while the bin field is properly updated. The PR also makes exports optional in the zshy config when a bin field is specified.
Key changes:
- Modified validation logic to allow zshy configs with only
bin(noexportsrequired) - Added comprehensive test case with fixtures for bin-only packages
- Updated workflow trigger path (appears unrelated to main PR purpose)
Reviewed changes
Copilot reviewed 4 out of 15 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/zshy.test.ts | Adds test verifying bin updates without modifying existing exports |
| test/bin/tsconfig.json | Test fixture: TypeScript config for bin-only test case |
| test/bin/src/cli.ts | Test fixture: Simple CLI entrypoint for bin test |
| test/bin/package.json | Test fixture: Package config with bin in zshy config and existing exports field |
| test/bin/dist/* | Test fixture: Pre-built output files for bin test (8 files) |
| test/snapshots/zshy.test.ts.snap | Snapshot of expected test output showing bin update without exports modification |
| src/main.ts | Makes exports optional in zshy config when bin is specified |
| .github/workflows/publish-latest.yml | Reorders workflow triggers and changes path filter from VERSION.txt to package.json |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| workflow_dispatch: # allow manual trigger for testing | ||
| push: | ||
| paths: | ||
| - 'VERSION.txt' |
There was a problem hiding this comment.
[nitpick] The workflow file changes (reordering triggers and changing from 'VERSION.txt' to 'package.json') appear to be unrelated to the PR's stated purpose of "Add simple bin test" and ensuring it doesn't set exports. Consider separating these workflow changes into a separate commit or PR for clarity.
|
❌ Claude Code process exited with code 1 |

Ensure it doesn't set
"exports"