fix: migrate to nusb 0.2.1 API #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: sjoerdsimons <22603932+sjoerdsimons@users.noreply.github.com>
Co-authored-by: sjoerdsimons <22603932+sjoerdsimons@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update nusb requirement from 0.1.10 to 0.2.1
fix: migrate to nusb 0.2.1 API
Nov 26, 2025
sjoerdsimons
requested changes
Nov 26, 2025
Collaborator
sjoerdsimons
left a comment
sjoerdsimons
left a comment
There was a problem hiding this comment.
Some small changes required, also the version should be updated as this is an api change
rockusb/src/nusb.rs
Outdated
| info: nusb::DeviceInfo, | ||
| ) -> std::result::Result<Self, DeviceUnavalable> { | ||
| let device = info.open()?; | ||
| let device = info.open().wait()?; |
rockusb/src/nusb.rs
Outdated
| input.address(), | ||
| output.address(), | ||
| )?)); | ||
| let interface = device.claim_interface(iface_setting.interface_number()).wait()?; |
rockusb/src/nusb.rs
Outdated
| /// List rockchip devices | ||
| pub fn devices() -> std::result::Result<impl Iterator<Item = DeviceInfo>, nusb::Error> { | ||
| Ok(nusb::list_devices()?.filter(|d| d.vendor_id() == 0x2207)) | ||
| Ok(nusb::list_devices().wait()?.filter(|d| d.vendor_id() == 0x2207)) |
rockusb/src/nusb.rs
Outdated
| data.copy_from_slice(&read); | ||
| // For IN transfers, requested_len must be a multiple of max_packet_size | ||
| let max_packet_size = self.ep_in.max_packet_size(); | ||
| let requested_len = ((data.len() + max_packet_size - 1) / max_packet_size) * max_packet_size; |
Collaborator
There was a problem hiding this comment.
Use next_multiple_of instead of open-coding it
Co-authored-by: sjoerdsimons <22603932+sjoerdsimons@users.noreply.github.com>
Author
All changes addressed in commit 5b9a24c:
|
Collaborator
|
@copilot Please fix the github action failures |
Co-authored-by: sjoerdsimons <22603932+sjoerdsimons@users.noreply.github.com>
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rockusb/src/nusb.rsto use new nusb 0.2.1 API:RequestBufferwithBufferbulk_in/bulk_outmethods withEndpoint<Bulk, In/Out>patterncontrol_outEndpointType::Bulkcomparison withTransferType::Bulklist_devices(),open(), andclaim_interface()next_multiple_offor packet size alignmentbusnum()instead ofbus_number().awaitfor async functions✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.