Disable password strength validation on /login#14
Open
Conversation
Member
|
@dobri1408 What are the steps to reproduce the error that you showed in the video? I tried entering a short password on the login page at https://classic.demo.plone.org/login, but I don't see this error message. |
Author
|
Hi @davisagli thank you for your review, in order to use this you need to install the add-on, but I see that on classic demo the addon is not present. |
Member
|
@dobri1408 Oh, got it. I totally overlooked that this is a PR for Products.PasswordStrength |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe password strength validation should only occur during registration or when changing the password, not during login, as it could prevent users from accessing the site.
screen-capture.14.webm