setup.py : conditional import of plone.z3cform for Plone >= 4.3#34
Open
ldaverio wants to merge 3 commits intocollective:masterfrom
ldaverio:master
Open
setup.py : conditional import of plone.z3cform for Plone >= 4.3#34ldaverio wants to merge 3 commits intocollective:masterfrom ldaverio:master
ldaverio wants to merge 3 commits intocollective:masterfrom
ldaverio:master
Conversation
added 3 commits
November 11, 2017 16:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I was trying to upgrade a Plone site from 4.2.6 to 4.3.15, and it looks like plone.app.z3cform has been renamed to plone.z3cform (without .app). A cursory glance at the two modules seems to show an identical, or very similar, content, so I think it's safe to solve the compatibility issue by just a conditional dependency in the setup.py file.
Laurent.