Remove usage of pkg_resources and update testing to GHA and modern python versions#100
Merged
Remove usage of pkg_resources and update testing to GHA and modern python versions#100
Conversation
mauritsvanrees
approved these changes
Feb 9, 2026
Member
mauritsvanrees
left a comment
There was a problem hiding this comment.
LGTM.
I do wonder about python_requires=">=3.11". Python 3.10 is still supported, so it would be good to allow. But I suppose this is just a tool that developers call, and it can use latest Python even when it generated code that still works with older versions. So I don't mind much.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pkg_resourcesto support newer setuptoolsI created this after seeing plone/plonecli#90
Perhaps we do not need to modernize mr.bob, but I think it is worth the effort, because it is just removing pkg_resources here and there.