Skip to content

Support method symbols in max_audits #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gathuku wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Support method symbols in max_audits #607

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b251114
support method symbols in max_audits
gathuku Dec 5, 2021
d0b7de6
use respond_to?
gathuku Dec 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/audited/auditor.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,6 +336,7 @@ def comment_required_state?

def combine_audits_if_needed
max_audits = audited_options[:max_audits]
max_audits = Integer(method(max_audits).call).abs if max_audits.is_a?(Symbol)
if max_audits && (extra_count = audits.count - max_audits) > 0
audits_to_combine = audits.limit(extra_count + 1)
combine_audits(audits_to_combine)
Expand Down Expand Up @@ -454,6 +455,8 @@ def normalize_audited_options
audited_options[:only] = Array.wrap(audited_options[:only]).map(&:to_s)
audited_options[:except] = Array.wrap(audited_options[:except]).map(&:to_s)
max_audits = audited_options[:max_audits] || Audited.max_audits
return if max_audits.is_a?(Symbol)

audited_options[:max_audits] = Integer(max_audits).abs if max_audits
end

Expand Down