New configurable settings: encryption for audited_changes & filtering encrypted attrs#694
Open
sriddbs wants to merge 4 commits intocollectiveidea:mainfrom
Open
Conversation
Contributor
Author
|
@danielmorrison please review and let me if the proposed config in the PR is good, also I wonder why some of the specs are failing 🤔 |
| Audited.filter_encrypted_attributes = false | ||
| ``` | ||
|
|
||
| If you want to encrypt the changes that are audited, you can simply add this line to your config |
Member
There was a problem hiding this comment.
Maybe another header here to show that these are separate features?
Contributor
Author
There was a problem hiding this comment.
hmm, because we use encrypts, this config is also available only from Rails 7 ... so I grouped it under the same header
should I add a sub-header?
Member
danielmorrison
left a comment
danielmorrison
left a comment
There was a problem hiding this comment.
Looking good to me. Test errors are something strange with coverage? Doesn't make sense offhand.
Contributor
Author
I had the same errors with for this it just runs fine |
Contributor
Author
|
@danielmorrison if this PR looks good, please merge? |
tvararu
added a commit
to nhsuk/manage-vaccinations-in-schools
that referenced
this pull request
May 29, 2024
Audited automatically replaces entries in the `audited_changes` field on audits with `[FILTERED]` for attributes that are encrypted. This is designed to prevent leaking of sensitive information in `audited_changes` which is an unencrypted field. The downside to this is that the `audited_changes` field now provides less information about what the audit actually changed. To solve this, collectiveidea/audited#694 adds additional configuration attributes: - `Audited.filter_encrypted_attributes = false` disables the automatic replacement with `[FILTERED]` - `Audited.encrypt_audited_changes = true` encrypts the actual entire `audited_changes` field, ensuring that sensitive information isn't leaked See: - collectiveidea/audited#690 - collectiveidea/audited#694
tvararu
reviewed
May 29, 2024
| serialize :audited_changes, YAMLIfTextColumnType | ||
| end | ||
|
|
||
| if Rails.gem_version >= Gem::Version.new("7.0") && Audited.encrypt_audited_changes |
There was a problem hiding this comment.
This doesn't seem to work as expected, it appears that this is evaluated before the Audited.encrypt_audited_changes = true in the initializer runs so it evaluates to false initially and is never re-evaluated. The encrypts call below never runs as a result.
tvararu
added a commit
to nhsuk/manage-vaccinations-in-schools
that referenced
this pull request
May 29, 2024
Audited automatically replaces entries in the `audited_changes` field on audits with `[FILTERED]` for attributes that are encrypted. This is designed to prevent leaking of sensitive information in `audited_changes` which is an unencrypted field. The downside to this is that the `audited_changes` field now provides less information about what the audit actually changed. To solve this, collectiveidea/audited#694 adds additional configuration attributes: - `Audited.filter_encrypted_attributes = false` disables the automatic replacement with `[FILTERED]` - `Audited.encrypt_audited_changes = true` encrypts the actual entire `audited_changes` field, ensuring that sensitive information isn't leaked See: - collectiveidea/audited#690 - collectiveidea/audited#694
tvararu
added a commit
to nhsuk/manage-vaccinations-in-schools
that referenced
this pull request
May 29, 2024
Audited automatically replaces entries in the `audited_changes` field on audits with `[FILTERED]` for attributes that are encrypted. This is designed to prevent leaking of sensitive information in `audited_changes` which is an unencrypted field. The downside to this is that the `audited_changes` field now provides less information about what the audit actually changed. To solve this, collectiveidea/audited#694 adds additional configuration attributes: - `Audited.filter_encrypted_attributes = false` disables the automatic replacement with `[FILTERED]` - `Audited.encrypt_audited_changes = true` encrypts the actual entire `audited_changes` field, ensuring that sensitive information isn't leaked See: - collectiveidea/audited#690 - collectiveidea/audited#694
tvararu
added a commit
to nhsuk/manage-vaccinations-in-schools
that referenced
this pull request
May 29, 2024
Audited automatically replaces entries in the `audited_changes` field on audits with `[FILTERED]` for attributes that are encrypted. This is designed to prevent leaking of sensitive information in `audited_changes` which is an unencrypted field. The downside to this is that the `audited_changes` field now provides less information about what the audit actually changed. To solve this, collectiveidea/audited#694 adds additional configuration attributes: - `Audited.filter_encrypted_attributes = false` disables the automatic replacement with `[FILTERED]` - `Audited.encrypt_audited_changes = true` encrypts the actual entire `audited_changes` field, ensuring that sensitive information isn't leaked See: - collectiveidea/audited#690 - collectiveidea/audited#694
|
How are you doing with PR? |
srg-bnd
reviewed
Jul 12, 2024
| end | ||
|
|
||
| if Rails.gem_version >= Gem::Version.new("7.0") && Audited.encrypt_audited_changes | ||
| encrypts :audited_changes |
There was a problem hiding this comment.
Is it necessary to take into account the deterministic encryption?
|
Just stumbled upon this PR. I'd love to have this functionality. Is anything blocking this currently @danielmorrison ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #690
encrypt_audited_changesdefault tofalsefilter_encrypted_attributesdefault totrue