Merged
Conversation
tirinnovo
reviewed
Oct 25, 2025
.github/workflows/ci.yml
Outdated
Comment on lines
+103
to
+105
| - ruby: '3.2' | ||
| gemfile: rails_8_1 | ||
|
|
Contributor
Author
There was a problem hiding this comment.
I added ruby 3.4 to the version matrix and included all the supported Ruby version for 8.1 (3.2, 3.3 & 3.4)
tvdeyen
added a commit
to AlchemyCMS/alchemy_cms
that referenced
this pull request
Nov 2, 2025
Needs a new version of awesome_nested_set collectiveidea/awesome_nested_set#495
tvdeyen
added a commit
to AlchemyCMS/alchemy_cms
that referenced
this pull request
Nov 2, 2025
Needs a new version of awesome_nested_set collectiveidea/awesome_nested_set#495
3 tasks
tvdeyen
added a commit
to AlchemyCMS/alchemy_cms
that referenced
this pull request
Nov 2, 2025
Needs a new version of awesome_nested_set collectiveidea/awesome_nested_set#495
tvdeyen
added a commit
to AlchemyCMS/alchemy_cms
that referenced
this pull request
Nov 7, 2025
Needs a new version of awesome_nested_set collectiveidea/awesome_nested_set#495
|
Hey @tirinnovo 👋 could you please review this PR again? Thanks 🙏 |
|
Following this thread |
|
👀 |
Closed
|
@danielmorrison Is this something you can help with, or relax the constraint so we don't hit it on every Rails version upgrade? I'm still using @caonUlisses' fork as I presume are many other people. This is such a great gem (and integral for lots of us); if there are problems with maintenance or it'd be better forked I'm sure plenty of us—I'd volunteer—would be happy to take on some of that responsibility! |
Collaborator
|
Did CI run? It's not showing that it ran.. |
Collaborator
parndt
approved these changes
Dec 20, 2025
Collaborator
|
Thanks @caonUlisses ! |
parndt
added a commit
that referenced
this pull request
Dec 20, 2025
These got missed on #495 so adding them in. I've updated it according to [FastRuby's compatibility matrix](https://www.fastruby.io/blog/ruby/rails/versions/compatibility-table.html).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is pretty much a copy of this PR that added rails 8.0 support.