Skip to content

Fix n+1 problem in save with server side defaults in pk #919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nicolaichuk wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix n+1 problem in save with server side defaults in pk #919

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions ormar/models/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,16 +91,19 @@ async def save(self: T) -> T:
expr = self.Meta.table.insert()
expr = expr.values(**self_fields)

pkname = self.Meta.pkname
is_need_load_pk = True
pk = await self.Meta.database.execute(expr)
if pk and isinstance(pk, self.pk_type()):
setattr(self, self.Meta.pkname, pk)
setattr(self, pkname, pk)
is_need_load_pk = False

self.set_save_status(True)
# refresh server side defaults
if any(
field.server_default is not None
for name, field in self.Meta.model_fields.items()
if name not in self_fields
if name not in self_fields and (is_need_load_pk or name != pkname)
):
await self.load()

Expand Down