Skip to content

Conversation

@byfnoel
Copy link
Contributor

@byfnoel byfnoel commented Jul 17, 2025

Warning

DO NOT MERGE BEFORE PR 28

This PR ensures we format all Rust Code on commits or PR. Previously, we did not have a mechanism to make sure Rust code follows conventional style guidelines.

Part of the effort for #26

@byfnoel byfnoel marked this pull request as ready for review July 19, 2025 00:32
@parksb
Copy link
Member

parksb commented Jul 19, 2025

Please check the conflict caused by merging #28.

@byfnoel byfnoel changed the title feat: [Requires PR 28] Format Rust code with rustfmt feat: Enforce consistent style in Rust code with rustfmt Jul 21, 2025
@byfnoel
Copy link
Contributor Author

byfnoel commented Jul 21, 2025

I think now this should be fine. @parksb

@parksb parksb merged commit 80b73d5 into collie-reader:main Jul 26, 2025
4 checks passed
@parksb
Copy link
Member

parksb commented Jul 26, 2025

Thank you!

@byfnoel
Copy link
Contributor Author

byfnoel commented Jul 26, 2025

Thank you for merging this @parksb. Happy to see we can now further improve the CI and expand the tests we have with no major frictions.

@byfnoel byfnoel deleted the rust-ci-fmt branch July 26, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants