Simplified and improved build importer implementations

example/migrating/javalib/3-maven-complete-large/build.mill

@@ -6,7 +6,9 @@
 > git remote add -f origin https://github.com/iluwatar/java-design-patterns
 > git checkout ede37bd05568b1b8b814d8e9a1d2bbd71d9d615d
 
-> ./mill init --jvm-id 21 # Repo needs Java >=21 to build and test
+> echo 21 > .mill-jvm-version # Repo needs Java >=21 to build and test
+
+> ./mill init
 
 > rm twin/src/test/java/com/iluwatar/twin/BallThreadTest.java # skip flaky test
 > rm actor-model/src/test/java/com/iluwatar/actor/ActorModelTest.java # skip flaky test

example/migrating/javalib/4-gradle-complete/build.mill

@@ -6,7 +6,9 @@
 > git remote add -f origin https://github.com/komamitsu/fluency.git
 > git checkout 2.7.3 # multi-module Java project that requires Java 16+
 
-> ./mill init --base-module FluencyModule --jvm-id 16
+> echo "16" > .mill-jvm-version
+
+> ./mill init
 converting Gradle build
 ...
 init completed, run "mill resolve _" to list available tasks

example/migrating/javalib/5-gradle-incomplete/build.mill

@@ -4,13 +4,14 @@
 
 > git init .
 > git remote add -f origin https://github.com/mockito/mockito.git
-> git checkout v5.15.2 # multi-module Java project that requires Java 17+
+> git checkout v5.19.0 # multi-module Java project that requires Java 11
 
-> ./mill init --base-module MockitoModule --jvm-id 17   # init ignores custom dependency configurations
+> echo "17" > .mill-jvm-version # Gradle version in use requires Java 17
+
+> ./mill init # imported modules are not fully functional
 converting Gradle build
-ignoring errorprone dependency (com.google.errorprone,error_prone_core,2.23.0)
 init completed, run "mill resolve _" to list available tasks
 
-> ./mill __.compile   # compilation error can be by fixed by using the Mill plugin for ErrorProne
-error: plug-in not found: ErrorProne
+> ./mill mockito-core.compile   # requires manual tweaking to support Java modules
+error: ...module not found: net.bytebuddy
 */

example/migrating/scalalib/2-sbt-incomplete/build.mill

@@ -3,17 +3,15 @@
 > rm build.mill # remove any existing build file
 
 > git init .
-> git remote add -f origin https://github.com/tototoshi/scala-csv.git
-> git checkout 2.0.0
+> git remote add -f origin https://github.com/fthomas/refined.git
+> git checkout v0.11.3
 
 > ./mill init
 converting sbt build
 ...
 init completed, run "mill resolve _" to list available tasks
 
-> ./mill compile # You will have to further configure the `CrossScalaModule` for different Scala versions
-compiling 7 Scala sources and 3 Java sources to ...
-error: class CSVReader protected (private val lineReader: LineReader)(implicit format: CSVFormat) extends Closeable with CSVReaderCompat {
-error:                                                                                                                   ^
-error: one error found
+> ./mill modules.core.jvm[2.12.20].compile # custom version range source roots 3.0+/3.0- not supported
+compiling 22 Scala sources to ...
+error: ...object boolean is not a member of package eu.timepit.refined
 */

integration/manual/migrating/src/MillInitGradleAsmTests.scala

@@ -0,0 +1,34 @@
+package mill.integration
+
+import mill.testkit.GitRepoIntegrationTestSuite
+import utest.*
+
+object MillInitGradleAsmTests extends GitRepoIntegrationTestSuite {
+
+  // gradle 8.3
+  def gitRepoUrl = "https://gitlab.ow2.org/asm/asm.git"
+  def gitRepoBranch = "ASM_9_8"
+
+  def tests = Tests {
+    test - integrationTest { tester =>
+      import tester.*
+
+      os.write(workspacePath / ".mill-jvm-version", "11")
+
+      eval("init", stdout = os.Inherit, stderr = os.Inherit).isSuccess ==> true
+      eval(("resolve", "_"), stdout = os.Inherit, stderr = os.Inherit).isSuccess ==> true
+      eval("asm.compile", stdout = os.Inherit, stderr = os.Inherit).isSuccess ==> true
+      eval("asm.publishLocal", stdout = os.Inherit, stderr = os.Inherit)
+
+      // modules are tested with asm-test module?
+      eval("asm.test", stdout = os.Inherit, stderr = os.Inherit).isSuccess ==> false
+
+      // custom sourceSets not supported
+      eval(
+        "tools.retrofitter.compile",
+        stdout = os.Inherit,
+        stderr = os.Inherit
+      ).isSuccess ==> false
+    }
+  }
+}

integration/manual/migrating/src/MillInitGradleEhcache3Tests.scala

@@ -0,0 +1,35 @@
+package mill.integration
+
+import mill.testkit.GitRepoIntegrationTestSuite
+import utest.*
+
+object MillInitGradleEhcache3Tests extends GitRepoIntegrationTestSuite {
+
+  // gradle 7.2
+  // custom dependency configurations
+  // dependencies with version constraints
+  // custom layout
+  // custom repository
+  // bom dependencies
+  // modules with pom packaging
+  // Junit4
+  def gitRepoUrl = "https://github.com/ehcache/ehcache3.git"
+  def gitRepoBranch = "v3.10.8"
+
+  def tests = Tests {
+    test - integrationTest { tester =>
+      import tester.*
+
+      // https://docs.gradle.org/current/userguide/compatibility.html#java_runtime
+      os.write(workspacePath / ".mill-jvm-version", "11")
+
+      eval("init", stdout = os.Inherit, stderr = os.Inherit).isSuccess ==> true
+      eval(("resolve", "_"), stdout = os.Inherit, stderr = os.Inherit).isSuccess ==> true
+      eval("ehcache-api.compile", stdout = os.Inherit, stderr = os.Inherit).isSuccess ==> true
+      eval("ehcache-api.test", stdout = os.Inherit, stderr = os.Inherit).isSuccess ==> true
+
+      // custom dependency configurations not supported
+      eval("ehcache-xml.compile", stdout = os.Inherit, stderr = os.Inherit).isSuccess ==> false
+    }
+  }
+}

integration/manual/migrating/src/MillInitGradleFastCsvTests.scala

@@ -0,0 +1,33 @@
+package mill.integration
+
+import mill.testkit.GitRepoIntegrationTestSuite
+import utest.*
+
+object MillInitGradleFastCsvTests extends GitRepoIntegrationTestSuite {
+
+  // gradle 9.0.0-rc-1
+  // Junit5
+  // uses ErrorProne
+  def gitRepoUrl = "https://github.com/osiegmar/FastCSV.git"
+  def gitRepoBranch = "v4.0.0"
+
+  def tests = Tests {
+    test - integrationTest { tester =>
+      import tester.*
+
+      os.write(workspacePath / ".mill-jvm-version", "17")
+
+      eval("init", stdout = os.Inherit, stderr = os.Inherit).isSuccess ==> true
+      eval(("resolve", "_"), stdout = os.Inherit, stderr = os.Inherit).isSuccess ==> true
+      eval("lib.compile", stdout = os.Inherit, stderr = os.Inherit).isSuccess ==> true
+      eval("lib.publishLocal", stdout = os.Inherit, stderr = os.Inherit).isSuccess ==> true
+
+      // requires support for Java modules
+      eval("example.compile", stdout = os.Inherit, stderr = os.Inherit).isSuccess ==> false
+
+      // junit-platform-launcher version is set implicitly (tasks.test.useJunitPlatform())
+      // https://docs.gradle.org/8.14.3/userguide/upgrading_version_8.html#test_framework_implementation_dependencies
+      eval("lib.test.compile", stdout = os.Inherit, stderr = os.Inherit).isSuccess ==> false
+    }
+  }
+}

integration/manual/migrating/src/MillInitGradleJCommanderTests.scala

@@ -0,0 +1,29 @@
+package mill.integration
+
+import mill.testkit.GitRepoIntegrationTestSuite
+import utest.*
+
+object MillInitGradleJCommanderTests extends GitRepoIntegrationTestSuite {
+
+  // gradle 8.9
+  // single module
+  // testng 7.0.0
+  def gitRepoUrl = "https://github.com/cbeust/jcommander.git"
+  def gitRepoBranch = "2.0"
+
+  def tests = Tests {
+    test - integrationTest { tester =>
+      import tester.*
+
+      os.write(workspacePath / ".mill-jvm-version", "11")
+
+      eval("init", stdout = os.Inherit, stderr = os.Inherit).isSuccess ==> true
+      eval(("resolve", "_"), stdout = os.Inherit, stderr = os.Inherit).isSuccess ==> true
+      eval("compile", stdout = os.Inherit, stderr = os.Inherit).isSuccess ==> true
+      eval("publishLocal", stdout = os.Inherit, stderr = os.Inherit).isSuccess ==> true
+
+      // annotations defined in main-module cannot be used in test-module?
+      eval("test.compile", stdout = os.Inherit, stderr = os.Inherit).isSuccess ==> false
+    }
+  }
+}

integration/manual/migrating/src/MillInitGradleMicroconfigTests.scala

@@ -0,0 +1,25 @@
+package mill.integration
+
+import mill.testkit.GitRepoIntegrationTestSuite
+import utest.*
+
+object MillInitGradleMicroconfigTests extends GitRepoIntegrationTestSuite {
+
+  // gradle 8.10.1
+  // uses spring-boot-dependencies BOM
+  // Junit5
+  def gitRepoUrl = "https://github.com/microconfig/microconfig.git"
+  def gitRepoBranch = "v4.9.5"
+
+  def tests = Tests {
+    test - integrationTest { tester =>
+      import tester.*
+
+      eval(("init", "-u"), stdout = os.Inherit, stderr = os.Inherit).isSuccess ==> true
+      eval(("resolve", "_"), stdout = os.Inherit, stderr = os.Inherit).isSuccess ==> true
+      eval("__.compile", stdout = os.Inherit, stderr = os.Inherit).isSuccess ==> true
+      eval("__.publishLocal", stdout = os.Inherit, stderr = os.Inherit).isSuccess ==> true
+      eval("__.test", stdout = os.Inherit, stderr = os.Inherit).isSuccess ==> true
+    }
+  }
+}

integration/manual/migrating/src/MillInitGradleMockitoTests.scala

@@ -0,0 +1,27 @@
+package mill.integration
+
+import mill.testkit.GitRepoIntegrationTestSuite
+import utest.*
+
+object MillInitGradleMockitoTests extends GitRepoIntegrationTestSuite {
+
+  // gradle 8.14.2
+  // contains BOM module
+  def gitRepoUrl = "https://github.com/mockito/mockito.git"
+  def gitRepoBranch = "v5.19.0"
+
+  def tests = Tests {
+    test - integrationTest { tester =>
+      import tester.*
+
+      // project requires Java 11 but Gradle version in use requires Java 17
+      os.write(workspacePath / ".mill-jvm-version", "17")
+
+      eval("init", stdout = os.Inherit, stderr = os.Inherit).isSuccess ==> true
+      eval(("resolve", "_"), stdout = os.Inherit, stderr = os.Inherit).isSuccess ==> true
+
+      // requires javacOptions for Java modules
+      eval("mockito-core.compile", stdout = os.Inherit, stderr = os.Inherit).isSuccess ==> false
+    }
+  }
+}

integration/manual/migrating/src/MillInitGradlePCollectionsTests.scala

@@ -0,0 +1,25 @@
+package mill.integration
+
+import mill.testkit.GitRepoIntegrationTestSuite
+import utest.*
+
+object MillInitGradlePCollectionsTests extends GitRepoIntegrationTestSuite {
+
+  // gradle 8.14.3
+  // single module
+  // Junit5
+  def gitRepoUrl = "https://github.com/hrldcpr/pcollections.git"
+  def gitRepoBranch = "v5.0.0"
+
+  def tests = Tests {
+    test - integrationTest { tester =>
+      import tester.*
+
+      eval("init", stdout = os.Inherit, stderr = os.Inherit).isSuccess ==> true
+      eval(("resolve", "_"), stdout = os.Inherit, stderr = os.Inherit).isSuccess ==> true
+
+      // https://github.com/com-lihaoyi/mill/issues/5782
+      eval("compile", stdout = os.Inherit, stderr = os.Inherit).isSuccess ==> false
+    }
+  }
+}

integration/manual/migrating/src/MillInitGradleSpotbugsTests.scala

@@ -0,0 +1,37 @@
+package mill.integration
+
+import mill.testkit.GitRepoIntegrationTestSuite
+import utest.*
+
+object MillInitGradleSpotbugsTests extends GitRepoIntegrationTestSuite {
+
+  // gradle 9.0.0
+  // custom dependency configurations
+  // dependencies with version constraints
+  // custom layout
+  // Junit5
+  def gitRepoUrl = "https://github.com/spotbugs/spotbugs.git"
+  def gitRepoBranch = "4.9.4"
+
+  def tests = Tests {
+    test - integrationTest { tester =>
+      import tester.*
+
+      eval("init", stdout = os.Inherit, stderr = os.Inherit).isSuccess ==> true
+      eval(("resolve", "_"), stdout = os.Inherit, stderr = os.Inherit).isSuccess ==> true
+      eval(
+        "spotbugs-annotations.compile",
+        stdout = os.Inherit,
+        stderr = os.Inherit
+      ).isSuccess ==> true
+      eval(
+        "spotbugs-annotations.publishLocal",
+        stdout = os.Inherit,
+        stderr = os.Inherit
+      ).isSuccess ==> true
+
+      // missing sources from custom layout
+      eval("spotbugs-tests.test", stdout = os.Inherit, stderr = os.Inherit).isSuccess ==> false
+    }
+  }
+}

integration/manual/migrating/src/MillInitGradleSpringFrameworkTests.scala

@@ -0,0 +1,29 @@
+package mill.integration
+
+import mill.testkit.GitRepoIntegrationTestSuite
+import utest.*
+
+object MillInitGradleSpringFrameworkTests extends GitRepoIntegrationTestSuite {
+
+  // gradle 8.14.3
+  // custom repository
+  // dependencies with version constraints
+  // BOM modules
+  // uses errorprone
+  def gitRepoUrl = "https://github.com/spring-projects/spring-framework.git"
+  def gitRepoBranch = "v6.2.10"
+
+  def tests = Tests {
+    test - integrationTest { tester =>
+      import tester.*
+
+      os.write(workspacePath / ".mill-jvm-version", "17")
+
+      eval("init", stdout = os.Inherit, stderr = os.Inherit).isSuccess ==> true
+      eval(("resolve", "_"), stdout = os.Inherit, stderr = os.Inherit).isSuccess ==> true
+
+      // requires support for dependency version constraints
+      eval("spring-jcl.compile", stdout = os.Inherit, stderr = os.Inherit).isSuccess ==> false
+    }
+  }
+}

integration/manual/migrating/src/MillInitMavenAntlr4Tests.scala

@@ -0,0 +1,22 @@
+package mill.integration
+
+import mill.testkit.GitRepoIntegrationTestSuite
+import utest.*
+
+object MillInitMavenAntlr4Tests extends GitRepoIntegrationTestSuite {
+
+  def gitRepoUrl = "https://github.com/antlr/antlr4.git"
+  def gitRepoBranch = "v4.11.1"
+
+  def tests = Tests {
+    test - integrationTest { tester =>
+      import tester.*
+
+      eval("init", stdout = os.Inherit, stderr = os.Inherit).isSuccess ==> true
+      eval(("resolve", "_"), stdout = os.Inherit, stderr = os.Inherit).isSuccess ==> true
+
+      // custom layout not supported
+      eval("__.compile", stdout = os.Inherit, stderr = os.Inherit).isSuccess ==> false
+    }
+  }
+}