[WIP] POC Opts (Args) concept #6129
Draft
+892
−364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lefou
force-pushed
the
tr-poc-args-type
branch
from
9f178f7 to
84c9c7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
BINARY BREAKING CHANGES!
Related to:
out/folder contents (more) reproducible and filesystem layout agnostic #3660 - Tracker issueThis PR contains:
The new
mill.api.optAPI containing the classesOpts,OptandOptGroup.A refactoring of various modules that contain configuration data potentially containing paths - this is a API breaking change to just proof the concept
In contrast to the proposal (#6057) the class is named
Opts, notArgs, since we already have amill.api.Argsclass used for other purposes.While this PR can be applied as-is, it's real effect only emerges when also PR #6031 is merged, since otherwise, the paths stored as part of the configuration data will not be relocatable.