Move BuildFileCls and RootModule.Info out of codegen to instead be instantiated reflectively#6985
Merged
lihaoyi merged 15 commits intocom-lihaoyi:mainfrom Apr 4, 2026
Merged
Conversation
lihaoyi
changed the title
BuildFileCls out of codegen to instead be instantiated reflectivelyBuildFileCls and RootModule.Info out of codegen to instead be instantiated reflectively
lihaoyi
force-pushed
the
no-codegen-buildfilecls
branch
from
883207c to
d29df12
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should help reduce the amount of stuff that we end up codegening and avoid bloating the
build.millcompile phase. After this, theCompiling XXX Scala Filesmessage that appears when compiling your build should match the actual number of build files you have, and no longer be a confusingly higher number