Skip to content

Make creating symlinks and hardlinks count as a read operation #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 2, 2025
Merged

Make creating symlinks and hardlinks count as a read operation #364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c83389
tweaks
lihaoyi Mar 2, 2025
5575f0a
tweaks
lihaoyi Mar 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions os/src/FileOps.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,7 +366,7 @@ object exists extends Function1[Path, Boolean] {
object hardlink {
def apply(link: Path, dest: Path) = {
checker.value.onWrite(link)
checker.value.onWrite(dest)
checker.value.onRead(dest)
Files.createLink(link.wrapped, dest.wrapped)
}
}
Expand All @@ -377,7 +377,7 @@ object hardlink {
object symlink {
def apply(link: Path, dest: FilePath, perms: PermSet = null): Unit = {
checker.value.onWrite(link)
checker.value.onWrite(dest match {
checker.value.onRead(dest match {
case p: RelPath => link / RelPath.up / p
case p: SubPath => link / RelPath.up / p
case p: Path => p
Expand Down
2 changes: 1 addition & 1 deletion os/test/src/CheckerTests.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ object CheckerTests extends TestSuite {
}
}
test("hardlink") - prepChecker { wd =>
intercept[WriteDenied] {
intercept[ReadDenied] {
os.hardlink(wd / "Linked.txt", rd / "File.txt")
}
os.exists(wd / "Linked.txt") ==> false
Expand Down