feat: string-based-union support#679
Draft
ThijsBroersen wants to merge 2 commits intocom-lihaoyi:mainfrom
Draft
Conversation
Member
|
I think the approach looks fine as a first draft, but my concern is how it scales to broader usages of union types? Apart from unions of literal I mainly to make sure there's some coherent approach that we can document and users can understand, and that whatever we implement now doesn't get in the way of implementing other union types in future since we'll be locking in the public API |
Author
|
See #682 for my idea on how this could be done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial draft of string based literal type union support.