refactor(editors/subscriber...): Naming in GOOSE/SMV Subscriber plugins (openscd#991)

* Improve terminology and headings for GOOSE and SMV subscribing plugins, closes openscd#729 and related to openscd#958

* Update snapshots

* Tidy up rebase

* Revert snapshots incorrectly added

* Update following review comments

* Update snapshots

* Make lists activatable, partly resolves openscd#958

* Update translations for later binding description

* Update snapshots

* Reset selection on first entry

* Remove unnecessary styling

* Tidying title generation logic and unnecessary imports

* Update German translation

Author: danyill

src/editors/GooseControlSubscription.ts

@@ -76,7 +76,7 @@ export default class GooseControlSubscriptionPlugin extends LitElement {
       <div class="container">
         ${view == View.PUBLISHER
           ? html`<goose-list class="row" .doc=${this.doc}></goose-list>`
-          : html`<ied-list class="row" .doc=${this.doc}></ied-list>`}
+          : html`<ied-list class="row" .doc=${this.doc} serviceType="goose"></ied-list>`}
         <subscriber-list-goose
           class="row"
           .doc=${this.doc}

src/editors/SampledValuesSubscription.ts

@@ -74,7 +74,7 @@ export default class SampledValuesSubscriberPlugin extends LitElement {
       <div class="container">
         ${view == View.PUBLISHER
           ? html`<smv-list class="row" .doc=${this.doc}></smv-list>`
-          : html`<ied-list class="row" .doc=${this.doc}></ied-list>`}
+          : html`<ied-list class="row" .doc=${this.doc} serviceType="smv"></ied-list>`}
         <subscriber-list-smv class="row" .doc=${this.doc}></subscriber-list-smv>
       </div>
     </div>`;

src/editors/subscription/foundation.ts

@@ -286,7 +286,7 @@ export class SubscriberListContainer extends LitElement {
   /** List holding all current subscribed Elements. */
   subscribedElements: ListElement[] = [];
 
-  /** List holding all current avaialble Elements which are not subscribed. */
+  /** List holding all current available Elements which are not subscribed. */
   availableElements: ListElement[] = [];
 
   /** Current selected IED (when in Subscriber view) */

src/editors/subscription/goose/goose-list.ts

@@ -87,10 +87,15 @@ export class GooseList extends LitElement {
     );
   }
 
+  protected firstUpdated(): void {
+    selectedGseControl = undefined;
+    selectedDataSet = undefined;
+  }
+
   render(): TemplateResult {
     return html` <section tabindex="0">
-      <h1>${translate('subscription.goose.publisherGoose.title')}</h1>
-      <filtered-list>
+      <h1>${translate('subscription.goose.publisher.title')}</h1>
+      <filtered-list activatable>
         ${getOrderedIeds(this.doc).map(
           ied =>
             html`

src/editors/subscription/goose/subscriber-list.ts

@@ -397,21 +397,25 @@ export class SubscriberList extends SubscriberListContainer {
 
     return view == View.PUBLISHER
       ? html`<h1>
-          ${translate('subscription.goose.publisherGoose.subscriberTitle', {
+          ${translate('subscription.goose.publisher.subscriberTitle', {
             selected: gseControlName
               ? this.currentGooseIedName + ' > ' + gseControlName
               : 'GOOSE',
           })}
         </h1>`
       : html`<h1>
-          ${translate('subscription.goose.subscriberGoose.publisherTitle', {
+          ${translate('subscription.goose.subscriber.publisherTitle', {
             selected: this.currentSelectedIed
               ? this.currentSelectedIed.getAttribute('name')!
               : 'IED',
           })}
         </h1>`;
   }
 
+  protected firstUpdated(): void {
+    this.currentSelectedIed = undefined
+  }
+
   render(): TemplateResult {
     return html`
       <section tabindex="0">

src/editors/subscription/ied-list.ts

@@ -27,6 +27,9 @@ export class IedList extends LitElement {
   @property()
   doc!: XMLDocument;
 
+  @property({ type: String })
+  serviceType?: 'goose' | 'smv';
+
   private onIedSelect(element: Element): void {
     selectedIed = element;
 
@@ -37,10 +40,14 @@ export class IedList extends LitElement {
     this.dispatchEvent(newIEDSelectEvent(selectedIed));
   }
 
+  protected firstUpdated(): void {
+    selectedIed = undefined;
+  }
+
   render(): TemplateResult {
     return html` <section tabindex="0">
-      <h1>${translate('subscription.iedList.title')}</h1>
-      <filtered-list>
+      <h1>${translate(`subscription.${this.serviceType}.subscriber.iedListTitle`)}</h1>
+      <filtered-list activatable>
         ${getOrderedIeds(this.doc).map(
           ied =>
             html`

src/editors/subscription/later-binding/ext-ref-later-binding-list.ts

@@ -14,15 +14,14 @@ import {
   cloneElement,
   compareNames,
   getDescriptionAttribute,
-  getNameAttribute,
   identity,
   newActionEvent,
   Replace,
   getSclSchemaVersion,
 } from '../../../foundation.js';
 
 import { styles, updateExtRefElement, serviceTypes } from '../foundation.js';
-import { FcdaSelectEvent, getFcdaTitleValue } from './foundation.js';
+import { FcdaSelectEvent } from './foundation.js';
 
 /**
  * A sub element for showing all Ext Refs from a FCDA Element.
@@ -236,19 +235,8 @@ export class ExtRefLaterBindingList extends LitElement {
   }
 
   private renderTitle(): TemplateResult {
-    const controlElementName = this.currentSelectedControlElement
-      ? getNameAttribute(this.currentSelectedControlElement)
-      : undefined;
-    const fcdaName = this.currentSelectedFcdaElement
-      ? getFcdaTitleValue(this.currentSelectedFcdaElement)
-      : undefined;
-
     return html`<h1>
-      ${translate('subscription.laterBinding.extRefList.title', {
-        controlTag: this.controlTag,
-        controlElementName: controlElementName ?? '-',
-        fcdaName: fcdaName ?? '-',
-      })}
+      ${translate(`subscription.laterBinding.extRefList.title`)}
     </h1>`;
   }
 

src/editors/subscription/later-binding/fcda-later-binding-list.ts

@@ -143,7 +143,7 @@ export class FCDALaterBindingList extends LitElement {
                 `subscription.laterBinding.${this.controlTag}.controlBlockList.title`
               )}
             </h1>
-            <filtered-list>
+            <filtered-list activatable>
               ${controlElements.map(controlElement => {
                 const fcdaElements = this.getFcdaElements(controlElement);
                 return html`

src/editors/subscription/sampledvalues/smv-list.ts

@@ -63,6 +63,11 @@ export class SmvPublisherList extends LitElement {
     );
   }
 
+  protected firstUpdated(): void {
+    selectedSmvMsg = undefined;
+    selectedDataSet = undefined;
+  }
+
   renderSmv(smvControl: Element): TemplateResult {
     return html`<mwc-list-item
       @click=${() => this.onSelect(smvControl)}
@@ -85,8 +90,8 @@ export class SmvPublisherList extends LitElement {
 
   render(): TemplateResult {
     return html` <section tabindex="0">
-      <h1>${translate('subscription.smv.publisherSmv.title')}</h1>
-      <filtered-list>
+      <h1>${translate('subscription.smv.publisher.title')}</h1>
+      <filtered-list activatable>
         ${getOrderedIeds(this.doc).map(
           ied =>
             html`

src/editors/subscription/sampledvalues/subscriber-list.ts

@@ -399,21 +399,25 @@ export class SubscriberList extends SubscriberListContainer {
 
     return view == View.PUBLISHER
       ? html`<h1>
-          ${translate('subscription.smv.publisherSmv.subscriberTitle', {
+          ${translate('subscription.smv.publisher.subscriberTitle', {
             selected: gseControlName
               ? this.currentSmvIedName + ' > ' + gseControlName
               : 'Sampled Value',
           })}
         </h1>`
       : html`<h1>
-          ${translate('subscription.smv.subscriberSmv.publisherTitle', {
+          ${translate('subscription.smv.subscriber.publisherTitle', {
             selected: this.currentSelectedIed
               ? this.currentSelectedIed.getAttribute('name')!
               : 'IED',
           })}
         </h1>`;
   }
 
+  protected firstUpdated(): void {
+    this.currentSelectedIed = undefined
+  }
+
   render(): TemplateResult {
     return html`
       <section tabindex="0">