Skip to content

Commit 58742c7

Browse files
author
Dennis Labordus
committed
Updated test.
Signed-off-by: Dennis Labordus <[email protected]>
1 parent 56283f2 commit 58742c7

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

app/src/test/java/org/lfenergy/compas/scl/data/rest/v1/CompasSclDataResourceAsEditorTest.java

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,11 @@
3838
@TestSecurity(user = "test-editor", roles = {"SCD_" + READ_ROLE, "SCD_" + CREATE_ROLE, "SCD_" + UPDATE_ROLE, "SCD_" + DELETE_ROLE})
3939
@JwtSecurity(claims = {
4040
// Default the claim "name" is configured for Who, so we will set this claim for the test.
41-
@Claim(key = "name", value = "Test Editor")
41+
@Claim(key = "name", value = CompasSclDataResourceAsEditorTest.USERNAME)
4242
})
4343
class CompasSclDataResourceAsEditorTest {
44+
public static final String USERNAME = "Test Editor";
45+
4446
@InjectMock
4547
private CompasSclDataService compasSclDataService;
4648

@@ -207,7 +209,7 @@ void create_WhenCalled_ThenServiceCalledAndUUIDRetrieved() {
207209
request.setElements(new ArrayList<>());
208210
request.getElements().add(scl);
209211

210-
when(compasSclDataService.create(eq(type), eq(name), eq("Test Editor"), eq(comment), any(Element.class))).thenReturn(uuid);
212+
when(compasSclDataService.create(eq(type), eq(name), eq(USERNAME), eq(comment), any(Element.class))).thenReturn(uuid);
211213

212214
var response = given()
213215
.pathParam(TYPE_PATH_PARAM, type)
@@ -220,7 +222,7 @@ void create_WhenCalled_ThenServiceCalledAndUUIDRetrieved() {
220222
.response();
221223

222224
assertEquals(uuid.toString(), response.xmlPath().getString("CreateResponse.Id"));
223-
verify(compasSclDataService, times(1)).create(eq(type), eq(name), eq("Test Editor"), eq(comment), any(Element.class));
225+
verify(compasSclDataService, times(1)).create(eq(type), eq(name), eq(USERNAME), eq(comment), any(Element.class));
224226
}
225227

226228
@Test
@@ -237,7 +239,7 @@ void update_WhenCalled_ThenServiceCalledAndNewUUIDRetrieved() {
237239
request.setElements(new ArrayList<>());
238240
request.getElements().add(scl);
239241

240-
doNothing().when(compasSclDataService).update(eq(type), eq(uuid), eq(changeSetType), eq("Test Editor"), eq(comment), any(Element.class));
242+
doNothing().when(compasSclDataService).update(eq(type), eq(uuid), eq(changeSetType), eq(USERNAME), eq(comment), any(Element.class));
241243

242244
given()
243245
.pathParam(TYPE_PATH_PARAM, type)
@@ -248,7 +250,7 @@ void update_WhenCalled_ThenServiceCalledAndNewUUIDRetrieved() {
248250
.then()
249251
.statusCode(204);
250252

251-
verify(compasSclDataService, times(1)).update(eq(type), eq(uuid), eq(changeSetType), eq("Test Editor"), eq(comment), any(Element.class));
253+
verify(compasSclDataService, times(1)).update(eq(type), eq(uuid), eq(changeSetType), eq(USERNAME), eq(comment), any(Element.class));
252254
}
253255

254256
@Test

0 commit comments

Comments
 (0)