Implemented correct query

Signed-off-by: Flurb <[email protected]>

Author: Flurb

app/src/test/java/org/lfenergy/compas/scl/data/rest/mock/CompasSclDataRepositoryMock.java

@@ -43,7 +43,7 @@ public String findByUUID(SclFileType type, UUID id, Version version) {
     }
 
     @Override
-    public boolean hasDuplicateSclName(SclFileType type, UUID id) {
+    public boolean hasDuplicateSclName(SclFileType type, String name) {
         throw new IllegalStateException("Mock method using Mockito. Only needed to startup.");
     }
 

repository-postgresql/src/main/java/org/lfenergy/compas/scl/data/repository/postgresql/CompasSclDataPostgreSQLRepository.java

@@ -11,6 +11,8 @@
 import org.lfenergy.compas.scl.data.model.Version;
 import org.lfenergy.compas.scl.data.repository.CompasSclDataRepository;
 import org.lfenergy.compas.scl.extensions.model.SclFileType;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 import javax.sql.DataSource;
 import java.sql.ResultSet;
@@ -22,6 +24,8 @@
 import static org.lfenergy.compas.scl.data.exception.CompasSclDataServiceErrorCode.*;
 
 public class CompasSclDataPostgreSQLRepository implements CompasSclDataRepository {
+
+    private static final Logger LOGGER = LoggerFactory.getLogger(CompasSclDataPostgreSQLRepository.class);
     private static final String SELECT_METADATA_CLAUSE = "select id, name, major_version, minor_version, patch_version ";
     private static final String SELECT_DATA_CLAUSE = "select scl_data ";
     private static final String FROM_CLAUSE = " from scl_file ";
@@ -157,7 +161,25 @@ public String findByUUID(SclFileType type, UUID id, Version version) {
 
     @Override
     public boolean hasDuplicateSclName(SclFileType type, String name) {
-        return false;
+        var sql = "SELECT DISTINCT ON (id) m.* "
+                + "FROM scl_file m "
+                + "WHERE m.type=? "
+                + "ORDER BY m.id, m.major_version desc, m.minor_version desc, m.patch_version desc";
+
+        try (var connection = dataSource.getConnection();
+             var stmt = connection.prepareStatement(sql)) {
+            stmt.setString(1, type.name());
+
+            try (var resultSet = stmt.executeQuery()) {
+                while (resultSet.next()) {
+                    var usedName = resultSet.getString(NAME_FIELD);
+                    if (usedName.equals(name)) return true;
+                }
+            }
+            return false;
+        } catch (SQLException exp) {
+            throw new CompasSclDataServiceException(POSTGRES_SELECT_ERROR_CODE, "Error select meta info from database!", exp);
+        }
     }
 
     @Override

service/src/main/java/org/lfenergy/compas/scl/data/service/impl/CompasSclDataServiceImpl.java

@@ -37,9 +37,6 @@
  * These methods contain standard behaviour that is executed for every type of repository.
  */
 public class CompasSclDataServiceImpl implements CompasSclDataService {
-
-    private static final Logger LOGGER = LoggerFactory.getLogger(CompasSclDataServiceImpl.class);
-
     private final CompasSclDataRepository repository;
     private final ElementConverter converter;
     private final SclElementProcessor sclElementProcessor;