Review comments

Signed-off-by: Flurb <[email protected]>

Author: Flurb

repository-postgresql/src/main/java/org/lfenergy/compas/scl/data/repository/postgresql/CompasSclDataPostgreSQLRepository.java

@@ -158,7 +158,7 @@ public String findByUUID(SclFileType type, UUID id, Version version) {
     @Override
     public boolean hasDuplicateSclName(SclFileType type, String name) {
         var sql = "SELECT DISTINCT ON (id) m.* "
-                + "FROM scl_file m "
+                + FROM_CLAUSE + "m "
                 + "WHERE m.type=? "
                 + "ORDER BY m.id, m.major_version desc, m.minor_version desc, m.patch_version desc";
 

repository-postgresql/src/test/java/org/lfenergy/compas/scl/data/repository/postgresql/CompasSclDataPostgreSQLRepositoryTest.java

@@ -29,10 +29,9 @@ void beforeEach() {
         repository = new CompasSclDataPostgreSQLRepository(PostgreSQLServerJUnitExtension.getDataSource());
     }
 
-    /**
+    /*
      * TODO: Method beneath needs to be moved to AbstractCompasSclDataRepository
-     * when hasDuplicateSclName has been implemented by CompasSclDataBaseXRepository.
-     */
+     * when hasDuplicateSclName has been implemented by CompasSclDataBaseXRepository. */
     @Test
     void hasDuplicateSclName_WhenUsingSclNameThatHasBeenUsedYet_ThenDuplicateIsFound() {
         var expectedVersion = new Version(1, 0, 0);

repository/src/main/java/org/lfenergy/compas/scl/data/repository/CompasSclDataRepository.java

@@ -74,7 +74,7 @@ public interface CompasSclDataRepository {
      * Return the specific version of a specific SCL Entry.
      *
      * @param type    The type of SCL to search for the specific SCL.
-     * @param id      The ID of the SCL to search for.
+     * @param name    The name of the SCL used for checking duplicates.
      * @return True if name is already used by another SCL File of the same File type, otherwise false.
      */
     @Transactional(SUPPORTS)

service/src/main/java/org/lfenergy/compas/scl/data/service/impl/CompasSclDataServiceImpl.java

@@ -121,7 +121,7 @@ public String create(SclFileType type, String name, String who, String comment,
             throw new CompasException(NO_SCL_ELEMENT_FOUND_ERROR_CODE, "No valid SCL found in the passed SCL Data.");
         }
 
-        if (hasDuplicateSclName(type, name)) {
+        if (repository.hasDuplicateSclName(type, name)) {
             throw new CompasException(DUPLICATE_SCL_NAME_ERROR_CODE, "Given name of SCL File already used.");
         }
 
@@ -167,7 +167,7 @@ public String update(SclFileType type, UUID id, ChangeSetType changeSetType, Str
 
         if (newFileName.isPresent()
             && !newFileName.get().equals(currentSclMetaInfo.getName())
-            && hasDuplicateSclName(type, newFileName.get())) {
+            && repository.hasDuplicateSclName(type, newFileName.get())) {
             throw new CompasException(DUPLICATE_SCL_NAME_ERROR_CODE, "Given name of SCL File already used.");
         }
 
@@ -213,10 +213,6 @@ public void delete(SclFileType type, UUID id, Version version) {
         repository.delete(type, id, version);
     }
 
-    private boolean hasDuplicateSclName(SclFileType type, String name) {
-        return repository.hasDuplicateSclName(type, name);
-    }
-
     /**
      * Retrieve the Header from the SCL Fiel or create one if it doesn't exists and set the ID and
      * version on the Header.