fix(#525): Bug : LNodeTypeAdapter.getDataAttributeRef should not throw exception Multiple Data Attribute found #526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w exception Multiple Data Attribute found Signed-off-by: massifben <[email protected]>
gleizesDor
reviewed
Sep 9, 2025
| @@ -14,6 +14,7 @@ | |||
| import org.lfenergy.compas.sct.commons.scl.SclRootAdapter; | |||
|
|
|||
There was a problem hiding this comment.
I've got 2 test failing in my IDE :
org.lfenergy.compas.sct.commons.scl.dtt.LNodeTypeAdapterTest#testHasSameContentAs
and
org.lfenergy.compas.sct.commons.scl.dtt.DataTypeTemplateAdapterTest#testImportLNodeType
org.lfenergy.compas.sct.commons.scl.dtt.DataTypeTemplateAdapterTest#testImportDTT
| .filter(dataAttributeRef -> dataRef.equals(dataAttributeRef.getDataAttributes())) | ||
| .reduce((dar1, dar2) -> { | ||
| // 2 data attribute ref with the same name in the same LNodeType means the SCL is not valid, according to XSD | ||
| throw new ScdException("Multiple Data Attribute found for this data reference '%s' in LNodeType.lnClass=%s, LNodeType.id=%s. Found DA : '%s' ".formatted(dataRef, getLNClass(), getId(), dar1)); |
gleizesDor
reviewed
Sep 10, 2025
| @@ -195,7 +193,7 @@ public List<DataAttributeRef> getDataAttributeRefs(@NonNull DataAttributeRef fil | |||
| } | |||
|
|
|||
| /** | |||
| * Return a list of summarized Data Attribute References beginning from given this LNodeType. | |||
| * Return a DataAttributeRef beginning from this LNodeType. | |||
gleizesDor
reviewed
Sep 10, 2025
| @@ -41,7 +41,7 @@ | |||
| * <li>{@link LNodeTypeAdapter#getId() <em>Returns the value of the <b>id </b>attribute</em>}</li> | |||
| * <li>{@link LNodeTypeAdapter#getLNClass <em>Returns the value of the <b>lnClass </b>attribute</em>}</li> | |||
| * <li>{@link LNodeTypeAdapter#getDataAttributeRefs(DataAttributeRef)} <em>Returns <b>DataAttributeRef </b> list</em>}</li> | |||
| * <li>{@link LNodeTypeAdapter#getDataAttributeRefs(String)} <em>Returns <b>DataAttributeRef </b> list</em>}</li> | |||
| * <li>{@link LNodeTypeAdapter#getDataAttributeRef(String)} <em>Returns <b>DataAttributeRef </b> list</em>}</li> | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.