fix: Ruby 3 keyword argument forwarding compatibility#1
Draft
khasinski wants to merge 1 commit intocombinaut:masterfrom
Draft
fix: Ruby 3 keyword argument forwarding compatibility#1khasinski wants to merge 1 commit intocombinaut:masterfrom
khasinski wants to merge 1 commit intocombinaut:masterfrom
Conversation
Use **options instead of extracting kwargs from *objects trailing hash. In Ruby 3, kwargs are no longer auto-converted from a trailing Hash in the positional args splat. Backward-compatible with Ruby 2.7.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
**optionsinstead of extracting kwargs from trailing Hash in*objects**optionstotransaction_without_retryIn Ruby 3, kwargs are no longer auto-converted from a trailing positional Hash. This change is backward-compatible with Ruby 2.5+.