[OPIK-4481] [FE] Update Optimization Studio table default columns#5279
Draft
YarivHashaiComet wants to merge 1 commit intomainfrom
Draft
[OPIK-4481] [FE] Update Optimization Studio table default columns#5279YarivHashaiComet wants to merge 1 commit intomainfrom
YarivHashaiComet wants to merge 1 commit intomainfrom
Conversation
Reorder DEFAULT_COLUMNS to match ticket spec: Status, Trial count, Best score, Created. Remove optimizer from DEFAULT_SELECTED_COLUMNS. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
📋 PR Linter Failed❌ Missing Section. The description is missing the |
![baz-reviewer[bot]](https://avatars.githubusercontent.com/in/933528?s=60&v=4){kind=small}
Comment on lines
163
to
+167
| export const DEFAULT_SELECTED_COLUMNS: string[] = [ | ||
| "created_at", | ||
| "status", | ||
| "num_trials", | ||
| "optimizer", | ||
| "objective_name", | ||
| "status", | ||
| "created_at", |
Contributor
There was a problem hiding this comment.
DEFAULT_SELECTED_COLUMNS was rewritten to include status/created and new ordering, but the page still reads optimizations-selected-columns from localStorage (lines ~250-254), so anyone who already has that key saved will keep their previous column set/order and never see the new defaults; can we migrate/reset stored selections or version the key so the updated defaults actually take effect?
Finding type: Logical Bugs
- Apply fix with Baz
Other fix methods
Prompt for AI Agents:
In apps/opik-frontend/src/components/pages/OptimizationsPage/OptimizationsPage.tsx
around lines 163-167 (DEFAULT_SELECTED_COLUMNS) and the localStorage read/write around
lines ~250-254, address that existing users keep the old saved column set. Implement a
migration or versioning strategy: either rename the storage key (e.g. append a version
suffix like optimizations-selected-columns-v2) or add a small migration function that
checks a stored schema/version value and, if outdated, replaces or merges the saved
columns with DEFAULT_SELECTED_COLUMNS and writes the updated value and new version back
to localStorage. Ensure the code falls back to DEFAULT_SELECTED_COLUMNS when the stored
value is invalid and add a comment explaining the version bump so future changes can
follow the same pattern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Update default column order and visibility for the Optimization Studio table. Reordered DEFAULT_COLUMNS to: Status, Trial count, Best score, Created, ID, Created by, Optimizer. Updated DEFAULT_SELECTED_COLUMNS to show: Status, Trial count, Best score, Created (removed Optimizer).
Change checklist
Issues
Testing
🤖 Generated with Claude Code