fix(cometbft): use correct key types #120
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melekes
added a commit
to informalsystems/tmkms-cometbft
that referenced
this pull request
Jul 31, 2025
|
Hi! Is this the latest change that needed to support cometbft v1 on the Cosmos SDK side? |
Contributor
Author
yep |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes incorrect public key type references in CometBFT light client test data by replacing the deprecated tendermint/PubKeyEd25519 format with the plain ed25519 format.
- Updates public key type format across multiple test JSON files
- Standardizes key type naming to match current CometBFT specifications
- Ensures consistency with the referenced GitHub issue about correct key types
Reviewed Changes
Copilot reviewed 47 out of 48 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| MC50_2_faulty_TestFailure.json | Updates all pub_key_type fields from tendermint/PubKeyEd25519 to ed25519 |
| MC4_4_faulty_TestValsetHalves.json | Updates all pub_key_type fields from tendermint/PubKeyEd25519 to ed25519 |
| MC4_4_faulty_TestValsetDoubles.json | Updates all pub_key_type fields from tendermint/PubKeyEd25519 to ed25519 |
| MC4_4_faulty_TestValsetDifferentAllSteps.json | Updates all pub_key_type fields from tendermint/PubKeyEd25519 to ed25519 |
| MC4_4_faulty_TestValsetChangesFully.json | Updates all pub_key_type fields from tendermint/PubKeyEd25519 to ed25519 |
| MC4_4_faulty_TestSuccess.json | Updates all pub_key_type fields from tendermint/PubKeyEd25519 to ed25519 |
| MC4_4_faulty_TestOneThirdValsetChanges.json | Updates all pub_key_type fields from tendermint/PubKeyEd25519 to ed25519 |
| MC4_4_faulty_TestNonMonotonicHeight.json | Updates all pub_key_type fields from tendermint/PubKeyEd25519 to ed25519 |
| MC4_4_faulty_TestMoreThanTwoThirdsSign.json | Updates all pub_key_type fields from tendermint/PubKeyEd25519 to ed25519 |
| MC4_4_faulty_TestLessThanTwoThirdsSign.json | Updates all pub_key_type fields from tendermint/PubKeyEd25519 to ed25519 |
| MC4_4_faulty_TestLessThanThirdValsetChanges.json | Updates all pub_key_type fields from tendermint/PubKeyEd25519 to ed25519 |
| MC4_4_faulty_TestHeaderNotWithinTrustingPeriod.json | Updates all pub_key_type fields from tendermint/PubKeyEd25519 to ed25519 |
| MC4_4_faulty_TestHeaderFromFuture.json | Updates all pub_key_type fields from tendermint/PubKeyEd25519 to ed25519 |
| MC4_4_faulty_TestHalfValsetChangesVerdictSuccess.json | Updates all pub_key_type fields from tendermint/PubKeyEd25519 to ed25519 |
| MC4_4_faulty_TestHalfValsetChangesVerdictNotEnoughTrust.json | Updates all pub_key_type fields from tendermint/PubKeyEd25519 to ed25519 |
| MC4_4_faulty_TestHalfValsetChanges.json | Updates all pub_key_type fields from tendermint/PubKeyEd25519 to ed25519 |
| MC4_4_faulty_TestFailure.json | Updates all pub_key_type fields from tendermint/PubKeyEd25519 to ed25519 |
| MC4_4_faulty_Test2NotEnoughTrustSuccess.json | Updates all pub_key_type fields from tendermint/PubKeyEd25519 to ed25519 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #115
tendermint/PubKeyEd25519was wrongly used instead of the plained25519(same for secp).