refactor(account): remove unused v1 module after ISA-2025-003 fix #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

kitay-sudo wants to merge 1 commit into cometbft:main from kitay-sudo:main

kitay-sudo commented Nov 29, 2025 •

edited by cursor bot

Loading

Summary

Removes the unused account::v1 module after the ISA-2025-003 security fix.

Changes

Replaced account::v1::try_from_type_and_bytes() with Id::from(PublicKey) in validator.rs
Removed the entire pub mod v1 from account.rs

Related

Closes #107

Note

Removes account::v1 and updates v1 validator conversions to validate addresses via Id::from(pub_key) with corresponding import adjustments.

Account (cometbft/src/account.rs):
- Remove legacy pub mod v1 and its try_from_type_and_bytes helper.
Validator (cometbft/src/validator.rs):
- v1 conversions: validate address by deriving from parsed pub_key using Id::from(pub_key).
- Update imports to use crate::account::Id.

^{Written by Cursor Bugbot for commit 45f18a4. This will update automatically on new commits. Configure here.}


          refactor(account): remove unused v1 module after ISA-2025-003 fix

45f18a4

The try_from_type_and_bytes function in account::v1 is no longer needed
since the address validation now uses Id::from(PublicKey) directly.
This simplifies the code and removes duplication.

Closes cometbft#107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet