ADR 013: Change proto generation tool to buf#16
Merged
Conversation
1 task
greg-szabo
reviewed
Feb 16, 2024
romac
reviewed
Feb 19, 2024
romac
reviewed
Feb 19, 2024
Collaborator
|
@romac @greg-szabo are you in favor of switching to |
There was a problem hiding this comment.
Pull Request Overview
This PR introduces ADR 013 to switch the proto generation tool to Buf and updates the ADR index to reference the new repository name.
- Add a new ADR outlining the decision to migrate to Buf for generating Rust bindings.
- Update the ADR directory README to reflect the
cometbft-rsproject name.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| docs/architecture/adr-013-proto-buf-serde.md | Add ADR 013 detailing the move to Buf with prost, prost-serde, and tonic. |
| docs/architecture/README.md | Update project name in ADR index from tendermint-rs to cometbft-rs. |
Comment on lines
3
to
+4
| This is a location to record all high-level architecture decisions in the | ||
| tendermint-rs project. | ||
| cometbft-rs project. |
There was a problem hiding this comment.
[nitpick] Consider merging this line with the previous one to form a complete sentence rather than splitting 'in the' across lines.
Contributor
|
I don't feel strongly either way, imho we should do whatever makes maintaining them easier. |
melekes
approved these changes
Jun 19, 2025
Collaborator
|
merging in a proposed status so we don't lose it. |
- expand on reasoning for serde in proto - mention the pbjson fork - record the decision on WKTs
melekes
force-pushed
the
mikhail/adr-013-proto-buf-serde
branch
from
79c2e68 to
3b1dd70
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rendered