-
Notifications
You must be signed in to change notification settings - Fork 3
Optimization and refactor #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 92c4dad The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #70 +/- ##
==========================================
+ Coverage 99.66% 99.79% +0.12%
==========================================
Files 18 18
Lines 2990 2906 -84
==========================================
- Hits 2980 2900 -80
+ Misses 10 6 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Ok the Unicode data here are too small for eytzinger to work. In fact, it is slightly slower than before (a few microseconds). One interesting observation is that if I do the sorting statically, the compression ratio suffers significantly compared to the ascending layout. brotli looks very good for similar sequences that appear in order. If I move the eytzinger sorting to the runtime, I can fix it, but it adds a small initialization cost. Since it doesn't improve any performance, I don't think it's worth introducing. |
8af9e23 to
95881f8
Compare
No description provided.