Skip to content

Conversation

@cometkim
Copy link
Owner

@cometkim cometkim commented Mar 5, 2025

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Mar 5, 2025

🦋 Changeset detected

Latest commit: 92c4dad

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
unicode-segmenter Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Mar 5, 2025

Codecov Report

Attention: Patch coverage is 98.05825% with 2 lines in your changes missing coverage. Please review.

Project coverage is 99.79%. Comparing base (5594e41) to head (92c4dad).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/grapheme.js 81.81% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #70      +/-   ##
==========================================
+ Coverage   99.66%   99.79%   +0.12%     
==========================================
  Files          18       18              
  Lines        2990     2906      -84     
==========================================
- Hits         2980     2900      -80     
+ Misses         10        6       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cometkim
Copy link
Owner Author

cometkim commented Mar 6, 2025

Ok the Unicode data here are too small for eytzinger to work. In fact, it is slightly slower than before (a few microseconds).

One interesting observation is that if I do the sorting statically, the compression ratio suffers significantly compared to the ascending layout. brotli looks very good for similar sequences that appear in order.

If I move the eytzinger sorting to the runtime, I can fix it, but it adds a small initialization cost. Since it doesn't improve any performance, I don't think it's worth introducing.

@cometkim cometkim force-pushed the micro-opt-2025 branch 2 times, most recently from 8af9e23 to 95881f8 Compare March 6, 2025 18:13
@cometkim cometkim marked this pull request as ready for review March 6, 2025 18:36
@cometkim cometkim merged commit 483d258 into main Mar 6, 2025
4 of 5 checks passed
@cometkim cometkim deleted the micro-opt-2025 branch March 6, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants