Optimize grapheme cluster boundary checking #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 844dd7a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #82 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 901 896 -5
=========================================
- Hits 901 896 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cometkim
force-pushed
the
opt-by-claude-verify-4
branch
from
25aa6c0 to
f1cf555
Compare
This reverts commit 96ddb2f.
cometkim
force-pushed
the
opt-by-claude-verify-4
branch
from
ae704d1 to
844dd7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A change suggested by Claude Code in #78
Not exactly the same as the suggested code, but inspired by it.
Prioritizing the most common cases (GB9, GB9a) does not seem to contribute to the perf improvement directly. However, it creates an opportunity to eliminate unnecessary branches.