Skip to content

Conversation

bigcat88
Copy link
Contributor

@bigcat88 bigcat88 commented Oct 1, 2025

Nodes were tests after conversion:

Screenshot From 2025-10-01 20-23-08

Git diff:

diff --git a/v3_object_info.json b/master_object_info.json
index 6f6a385..29b4d21 100644
--- a/v3_object_info.json
+++ b/master_object_info.json
@@ -4253,13 +4253,9 @@
         "input": {
             "required": {
                 "model_name": [
-                    "COMBO",
-                    {
-                        "multiselect": false,
-                        "options": [
-                            "4x-UltraSharp.pth"
-                        ]
-                    }
+                    [
+                        "4x-UltraSharp.pth"
+                    ]
                 ]
             }
         },
@@ -4277,29 +4273,21 @@
         "output_name": [
             "UPSCALE_MODEL"
         ],
-        "output_tooltips": [
-            null
-        ],
         "name": "UpscaleModelLoader",
         "display_name": "Load Upscale Model",
         "description": "",
         "python_module": "comfy_extras.nodes_upscale_model",
         "category": "loaders",
-        "output_node": false,
-        "deprecated": false,
-        "experimental": false,
-        "api_node": false
+        "output_node": false
     },
     "ImageUpscaleWithModel": {
         "input": {
             "required": {
                 "upscale_model": [
-                    "UPSCALE_MODEL",
-                    {}
+                    "UPSCALE_MODEL"
                 ],
                 "image": [
-                    "IMAGE",
-                    {}
+                    "IMAGE"
                 ]
             }
         },
@@ -4318,18 +4306,12 @@
         "output_name": [
             "IMAGE"
         ],
-        "output_tooltips": [
-            null
-        ],
         "name": "ImageUpscaleWithModel",
         "display_name": "Upscale Image (using Model)",
         "description": "",
         "python_module": "comfy_extras.nodes_upscale_model",
         "category": "image/upscaling",
-        "output_node": false,
-        "deprecated": false,
-        "experimental": false,
-        "api_node": false
+        "output_node": false
     },
     "ImageBlend": {
         "input": {

@bigcat88 bigcat88 requested a review from Kosinkadink as a code owner October 1, 2025 17:25
@bigcat88
Copy link
Contributor Author

bigcat88 commented Oct 1, 2025

+label: Core

@comfy-pr-bot comfy-pr-bot added the Core Core team dependency label Oct 1, 2025
@Kosinkadink
Copy link
Collaborator

Diff looks good, but there are 21 node packs to notify. We can merge it in next Wednesday (Oct. 8th) at the earliest.

@Kosinkadink Kosinkadink added the Scheduled Merge PR is reviewed and ready, but will be merged at a specific time. label Oct 1, 2025
This was referenced Oct 2, 2025
@Kosinkadink
Copy link
Collaborator

All 21 node authors are notified.

@Lex-DRL
Copy link

Lex-DRL commented Oct 3, 2025

@bigcat88
FYI: Every GitHub PR automatically has a git diff. Just add .diff to the URL: https://github.com/comfyanonymous/ComfyUI/pull/10149.diff

@bigcat88
Copy link
Contributor Author

bigcat88 commented Oct 3, 2025

Hello. It is not a git diff(patch) from the PR changes, it is git diff of ComfyUI node definitions.

@Kosinkadink
Copy link
Collaborator

Yep, comparing the diff of ComfyUI's /object_info endpoint lets us make sure the nodes are effectively the same in terms of what is being reported to the frontend - avoids accidentally messing up default, min, max, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Core team dependency Scheduled Merge PR is reviewed and ready, but will be merged at a specific time.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants