-
Notifications
You must be signed in to change notification settings - Fork 10.1k
[V3] convert nodes_upscale_model.py to V3 schema #10149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
+label: Core |
Diff looks good, but there are 21 node packs to notify. We can merge it in next Wednesday (Oct. 8th) at the earliest. |
All 21 node authors are notified. |
@bigcat88 |
Hello. It is not a git diff(patch) from the PR changes, it is git diff of ComfyUI node definitions. |
Yep, comparing the diff of ComfyUI's /object_info endpoint lets us make sure the nodes are effectively the same in terms of what is being reported to the frontend - avoids accidentally messing up default, min, max, etc. |
Nodes were tests after conversion:
Git diff: