Skip to content

Conversation

bigcat88
Copy link
Contributor

@bigcat88 bigcat88 commented Oct 3, 2025

Node was tested after conversion:

Screenshot From 2025-10-03 19-29-24

Git diff:

diff --git a/v3_object_info.json b/master_object_info.json
index 3e97d5a..1e69296 100644
--- a/v3_object_info.json
+++ b/master_object_info.json
@@ -20742,8 +20742,7 @@
                 "filename_prefix": [
                     "STRING",
                     {
-                        "default": "loras/ComfyUI_extracted_lora",
-                        "multiline": false
+                        "default": "loras/ComfyUI_extracted_lora"
                     }
                 ],
                 "rank": [
@@ -20756,14 +20755,10 @@
                     }
                 ],
                 "lora_type": [
-                    "COMBO",
-                    {
-                        "multiselect": false,
-                        "options": [
-                            "standard",
-                            "full_diff"
-                        ]
-                    }
+                    [
+                        "standard",
+                        "full_diff"
+                    ]
                 ],
                 "bias_diff": [
                     "BOOLEAN",
@@ -20785,14 +20780,6 @@
                         "tooltip": "The CLIPSubtract output to be converted to a lora."
                     }
                 ]
-            },
-            "hidden": {
-                "prompt": [
-                    "PROMPT"
-                ],
-                "extra_pnginfo": [
-                    "EXTRA_PNGINFO"
-                ]
             }
         },
         "input_order": {
@@ -20805,25 +20792,17 @@
             "optional": [
                 "model_diff",
                 "text_encoder_diff"
-            ],
-            "hidden": [
-                "prompt",
-                "extra_pnginfo"
             ]
         },
         "output": [],
         "output_is_list": [],
         "output_name": [],
-        "output_tooltips": [],
         "name": "LoraSave",
         "display_name": "Extract and Save Lora",
         "description": "",
         "python_module": "comfy_extras.nodes_lora_extract",
         "category": "_for_testing",
-        "output_node": true,
-        "deprecated": false,
-        "experimental": true,
-        "api_node": false
+        "output_node": true
     },
     "TorchCompileModel": {
         "input": {

note: node doesn't use metadata - difference in PROMPT and EXTRA_PNGINFO should be ok?

@bigcat88 bigcat88 requested a review from Kosinkadink as a code owner October 3, 2025 16:26
@bigcat88
Copy link
Contributor Author

bigcat88 commented Oct 3, 2025

+label: Core

@Kosinkadink
Copy link
Collaborator

Yep, should be fine. If i recall correctly, i made V3 automatically add those two hidden params if the node is marked as an output node.

Node authors notified, will merge on Wednesday Oct. 8th with the queued batch of V3 PRs.

@Kosinkadink Kosinkadink added the Scheduled Merge PR is reviewed and ready, but will be merged at a specific time. label Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Core team dependency Scheduled Merge PR is reviewed and ready, but will be merged at a specific time.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants