Skip to content

Update nodes_qwen.py #10193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −3
Open

Update nodes_qwen.py #10193

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions comfy_extras/nodes_qwen.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,10 +87,15 @@ def execute(cls, clip, prompt, vae=None, image1=None, image2=None, image3=None)
s = comfy.utils.common_upscale(samples, width, height, "area", "disabled")
images_vl.append(s.movedim(1, -1))
if vae is not None:
# compute optimal scale factor to get as close to 1024x1024 as possible while keeping dimensions multiples of 8
total = int(1024 * 1024)
scale_by = math.sqrt(total / (samples.shape[3] * samples.shape[2]))
width = round(samples.shape[3] * scale_by / 8.0) * 8
height = round(samples.shape[2] * scale_by / 8.0) * 8
s_ideal = math.sqrt(total / (samples.shape[3] * samples.shape[2]))
common_divisor = math.gcd(samples.shape[3], samples.shape[2])
p = samples.shape[3] // common_divisor
lcm = abs(p * 8) // math.gcd(p, 8)
s_optimal = (round(s_ideal * samples.shape[3] / lcm) * lcm) / samples.shape[3]
width = int(s_optimal * samples.shape[3])
height = int(s_optimal * samples.shape[2])

s = comfy.utils.common_upscale(samples, width, height, "area", "disabled")
ref_latents.append(vae.encode(s.movedim(1, -1)[:, :, :, :3]))
Expand Down