#3 - optimize comfyCmpMap count values; update docs (#17)

maciej-sz · web-flow · commit 0531fcbb47cd · 2025-03-10T23:43:43.000+01:00
diff --git a/README.adoc b/README.adoc
@@ -1,16 +1,23 @@
-= What is Comfy Gopher?
+= Comfy Gopher - Collections
+
+image:https://codecov.io/gh/comfygopher/collections/graph/badge.svg?token=I5QQ2SU3E7[codecov,link=https://codecov.io/gh/comfygopher/collections]
+
+image:https://img.shields.io/coderabbit/prs/github/comfygopher/collections?utm_source=oss&utm_medium=github&utm_campaign=comfygopher%2Fcollections&labelColor=171717&color=FF570A&link=https%3A%2F%2Fcoderabbit.ai&label=CodeRabbit+Reviews[CodeRabbit Pull Request Reviews]
+
+== What is Comfy Gopher?
 
 *Comfy Gopher is a Set of general-purpose Tools, Utilities, and Data Structures for Comfortable Development*
 
 These tools prioritize speed and ease of development over strict efficiency or full compliance with Go philosophy.
 They accelerate development and enhance the experience, by reducing the cognitive load,
 making them well suited for rapid prototyping.
 
-== Comfy Gopher - Collections
+== Comfy Gopher - Collections package
 
 === Goals
 
 1. Provide convenient abstraction for collection data structures
+1. Focus on developer experience
 1. Reduce repetition in day-to-day collections operations
 1. Address the missing ordered map data structure
 1. Provide API for in-place modifications of collections
diff --git a/mapcmp.go b/mapcmp.go
@@ -89,19 +89,15 @@ func (c *comfyCmpMap[K, V]) Contains(predicate Predicate[Pair[K, V]]) bool {
 }
 
 func (c *comfyCmpMap[K, V]) ContainsValue(v V) bool {
-	return comfyContains[Base[Pair[K, V]], Pair[K, V]](c, func(_ int, pair Pair[K, V]) bool {
-		return pair.Val() == v
-	})
+	return c.vc.Count(v) > 0
 }
 
 func (c *comfyCmpMap[K, V]) Count(predicate Predicate[Pair[K, V]]) int {
 	return comfyCount[Indexed[Pair[K, V]], Pair[K, V]](c, predicate)
 }
 
 func (c *comfyCmpMap[K, V]) CountValues(v V) int {
-	return comfyCount[Indexed[Pair[K, V]], Pair[K, V]](c, func(_ int, pair Pair[K, V]) bool {
-		return pair.Val() == v
-	})
+	return c.vc.Count(v)
 }
 
 func (c *comfyCmpMap[K, V]) Each(f Visitor[Pair[K, V]]) {

Original file line number	Diff line number	Diff line change
`@@ -89,19 +89,15 @@ func (c *comfyCmpMap[K, V]) Contains(predicate Predicate[Pair[K, V]]) bool {`
`89`	`89`	`}`
`90`	`90`
`91`	`91`	`func (c *comfyCmpMap[K, V]) ContainsValue(v V) bool {`
`92`		`- return comfyContains[Base[Pair[K, V]], Pair[K, V]](c, func(_ int, pair Pair[K, V]) bool {`
`93`		`- return pair.Val() == v`
`94`		`- })`
	`92`	`+ return c.vc.Count(v) > 0`
`95`	`93`	`}`
`96`	`94`
`97`	`95`	`func (c *comfyCmpMap[K, V]) Count(predicate Predicate[Pair[K, V]]) int {`
`98`	`96`	`return comfyCount[Indexed[Pair[K, V]], Pair[K, V]](c, predicate)`
`99`	`97`	`}`
`100`	`98`
`101`	`99`	`func (c *comfyCmpMap[K, V]) CountValues(v V) int {`
`102`		`- return comfyCount[Indexed[Pair[K, V]], Pair[K, V]](c, func(_ int, pair Pair[K, V]) bool {`
`103`		`- return pair.Val() == v`
`104`		`- })`
	`100`	`+ return c.vc.Count(v)`
`105`	`101`	`}`
`106`	`102`
`107`	`103`	`func (c *comfyCmpMap[K, V]) Each(f Visitor[Pair[K, V]]) {`