Dwk601: Migrate from react to SolidJS#157
Closed
dwk601 wants to merge 24 commits intocommaai:masterfrom
Closed
Conversation
…environment settings
…ed state management in SolidJS
…ve error handling
…ed value handling
… improved error handling
- Introduced a new asset management module to handle public assets directly. - Updated App.jsx and Flash.jsx to utilize the new asset management system for image imports. - Added new SVG and PNG assets for improved UI elements. - Implemented asset preloading for critical images to enhance performance. - Created unit tests for asset management functions to ensure reliability.
- Added @solidjs/testing-library version 0.8.5 to devDependencies - Removed duplicate @solidjs/testing-library entry - Added terser version 5.43.1 to devDependencies
… and monitoring steps
…ation for SolidJS
…idating configurations
Collaborator
|
Thanks for the PR, but 7k new lines for this little flasher clearly isn't simpler. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant changes to migrate the application from React to SolidJS, simplify the asset management and testing strategies, and improve performance. Key updates include the addition of SolidJS components, a streamlined test suite, and documentation updates to reflect the migration. Still working on finalizing it (13/15 tasks)
Migration to SolidJS:
SolidJSapplication entry point (index-solid.html) with updated asset paths and removed React-specific dependencies. [1] [2]Appcomponent (src-solid/App.jsx) with minimal state management and direct rendering of core features.Asset Management Improvements:
docs/ASSET_MANAGEMENT.md, emphasizing direct serving of static assets, zero build-time processing, and browser caching.Testing Strategy Overhaul:
docs/TESTING_STRATEGY.mdto outline a minimal test philosophy focused on essential functionality and performance improvements.docs/TEST_BENCHMARKS.md, highlighting runtime reductions and improved reliability.Package Updates:
package.jsonand added SolidJS-specific testing libraries.package-solid.jsonfile for SolidJS-specific configurations.These changes collectively enhance the application's performance, simplify its architecture, and align with the migration goals.