Car diff #3024
Merged
Car diff #3024
+453
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
CI / testing
car
elkoled
force-pushed
the
opendbc_replay
branch
from
f8f9a6b to
61f4b57
Compare
* add replay POC * compare HEAD to master * split in compare and worker * copy worker.py * cleanup * fix * apply tesla brake PR * fix * fix mutation test * add panda * add timestamps * simplify * add falling edge * add remaining carstate * simple lines * bump * rename * use zst as ref * ref commit * cleanup * formatting * no failing * fix git * clean * use pool.map * fix docker build * clean * Revert "fix docker build" This reverts commit da35774. * use flat paths * format * use azure test instance * print full diff * no stderr output * use GIT_REF * Revert "apply tesla brake PR" This reverts commit f377e21. * allow overwrite blobs * supress stderr
elkoled
force-pushed
the
opendbc_replay
branch
from
61f4b57 to
e9968a0
Compare
* add replay POC * compare HEAD to master * split in compare and worker * copy worker.py * cleanup * fix * apply tesla brake PR * fix * fix mutation test * add panda * add timestamps * simplify * add falling edge * add remaining carstate * simple lines * bump * rename * use zst as ref * ref commit * cleanup * formatting * no failing * fix git * clean * use pool.map * fix docker build * clean * Revert "fix docker build" This reverts commit da35774. * use flat paths * format * use azure test instance * print full diff * no stderr output * use GIT_REF * Revert "apply tesla brake PR" This reverts commit f377e21. * allow overwrite blobs * supress stderr * print upload refs * add error on failed generation * Revert "use azure test instance" This reverts commit ba969cc. * Revert "fix mutation test" This reverts commit 8f5e01d. * detect safety changes * use logReader * only use valid platforms * use local database * Revert "use local database" This reverts commit 4ebe9fe. * Reapply "use azure test instance" This reverts commit e9968a0.
This reverts commit ba969cc.
github-actions
bot
added
subaru
tesla
toyota
car safety
This reverts commit 692e34c.
github-actions
bot
added
honda
and removed
tesla
car safety
This reverts commit 91c4a5d.
This comment was marked as outdated.
This comment was marked as outdated.
adeebshihadeh
approved these changes
Jan 19, 2026
Contributor
adeebshihadeh
left a comment
adeebshihadeh
left a comment
There was a problem hiding this comment.
LGTM, aside from those minor comments. Feel free to merge once those are addressed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Car diff - CarState regression testing
This PR implements a diff method to catch behavioral changes in CarState by replaying a subset of carCommaSegments through CarInterface and comparing their CarState output against master refs in ci-artifacts.
Example:
elkoled#245
CI
Usage
auto-detect platform
source setup.sh && python opendbc/car/tests/car_diff.pytest specific platform
source setup.sh && python opendbc/car/tests/car_diff.py --platform TOYOTA_COROLLACI Benchmark
Measured on standard gh actions runner