Mazda: Add cruise button events for accel and decel #3027
+12
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sshane
reviewed
Jan 15, 2026
Comment on lines
+121
to
+126
| # cruise control button events: distance, inc, and dec | ||
| ret.buttonEvents = [ | ||
| *create_button_events(self.distance_button, prev_distance_button, {1: ButtonType.gapAdjustCruise}), | ||
| *create_button_events(self.accel_button, prev_accel_button, {1: ButtonType.accelCruise}), | ||
| *create_button_events(self.decel_button, prev_decel_button, {1: ButtonType.decelCruise}), | ||
| ] |
Contributor
There was a problem hiding this comment.
I don't believe openpilot uses these buttons for anything functional yet since this car is pcmCruise, is that correct?
Contributor
Author
There was a problem hiding this comment.
Yes, that’s correct. This change just exposes the existing INC/DEC button signals in CarState, and resolves the TODO without altering behavior. It should make the signals available if they’re needed in the future.
Contributor
|
Testing 17 segments for: MAZDA_CX5, MAZDA_CX9_2021, MAZDA_CX5_2022 Results: 16 passed, 1 with diffs, 0 errors |
|
a feedback to you , carrotpilot use this to CLSC , and works good on my CX-5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements TODO to add cruise control button events for accel and decel on Mazda platforms.
No functional behavior change; exposes existing CAN signals to CarState.
Validation
Dongle ID: N/A
Route: N/A