-
Notifications
You must be signed in to change notification settings - Fork 3
Make sure the header for Job Token matches the type of Token #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gpickin
wants to merge
24
commits into
master
Choose a base branch
from
gitlabPublicizerFix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
1f7cfd2
Make sure the header for Job Token matches the type of Tokens
gpickin 6baecae
Reset PreRelease and BuildID when getting last version
gpickin 0e91ac7
Fix the BuildID
gpickin ed339ec
Add default buildID of 0
gpickin 64ec70f
Add more verbose debugging
gpickin a54ced5
Fix Verbose issue in versionInfo
gpickin 94bf58b
Update Private-Token to Job-Token
gpickin 36d5cad
Test different token
gpickin 57c062a
Update gitlab token
gpickin 00bd867
Update gitlab tokens
gpickin 8120bb8
Clean up duplicate config
gpickin 1f9fe31
Ensure the targetBranch is passed to ConditionsVerifier
gpickin 22c396c
Change gitlab tokens back to CI_JOB_TOKEN
gpickin f7d68d6
Add NullNotesGenerator to plugins
gpickin f6ba53e
Add Null Notes Generator to config - reordered to sync plugins.
gpickin 48e11aa
Clean up ReadMe
gpickin 76c989d
Add NullChangeLogCommitter
gpickin 693eb60
Add optional config for skipping box.json updates
gpickin 5f45c49
Add gitlab box,json fix
gpickin 177d469
Add options Injection
gpickin 16fef1c
added getPackageVersion to create better starting version
gpickin cc8b267
Update for first versions to allow preReleaseID and buildID
gpickin 27faff0
Fix the prerelease an buildID from past versions
gpickin 7202acc
Fix Gitlab Fetcher Array Syntax
gpickin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,7 +10,6 @@ component { | |
| "changelogFileName" = "CHANGELOG.md", | ||
| "targetBranch" = "master", | ||
| "buildCommitMessage" = "__SEMANTIC RELEASE VERSION UPDATE__", | ||
|
|
||
| "plugins-VerifyConditions" = "GitHubActionsConditionsVerifier@commandbox-semantic-release", | ||
| "plugins-VerifyConditions-buildTimeout" = 600, // seconds | ||
| "plugins-VerifyConditions-pollingInterval" = 5, // seconds | ||
|
|
@@ -25,55 +24,59 @@ component { | |
| "plugins-CommitArtifacts" = "GitHubArtifactsCommitter@commandbox-semantic-release", | ||
| "plugins-CommitArtifacts-authorName" = "CommandBox Semantic Release", | ||
| "plugins-CommitArtifacts-authorEmail" = "[email protected]", | ||
| "plugins-CommitArtifacts-commitBoxJson" = true, | ||
| "plugins-PublishRelease" = "ForgeBoxReleasePublisher@commandbox-semantic-release", | ||
| "plugins-PublicizeRelease" = "GitHubReleasePublicizer@commandbox-semantic-release" | ||
| }; | ||
|
|
||
| binder.map( "TravisConditionsVerifier@commandbox-semantic-release" ) | ||
| .to( "#moduleMapping#.models.plugins.TravisConditionsVerifier" ); | ||
| binder.map( "NullConditionsVerifier@commandbox-semantic-release" ) | ||
| .to( "#moduleMapping#.models.plugins.NullConditionsVerifier" ); | ||
| binder.map( "GitLabConditionsVerifier@commandbox-semantic-release" ) | ||
| .to( "#moduleMapping#.models.plugins.GitLabConditionsVerifier" ); | ||
| binder.map( "GitHubActionsConditionsVerifier@commandbox-semantic-release" ) | ||
| .to( "#moduleMapping#.models.plugins.GitHubActionsConditionsVerifier" ); | ||
| binder.map( "ForgeBoxReleaseFetcher@commandbox-semantic-release" ) | ||
| .to( "#moduleMapping#.models.plugins.ForgeBoxReleaseFetcher" ); | ||
| binder.map( "JGitCommitsRetriever@commandbox-semantic-release" ) | ||
| .to( "#moduleMapping#.models.plugins.JGitCommitsRetriever" ); | ||
| binder.map( "ConventionalChangelogParser@commandbox-semantic-release" ) | ||
| .to( "#moduleMapping#.models.plugins.ConventionalChangelogParser" ); | ||
| binder.map( "EmojiLogCommitParser@commandbox-semantic-release" ) | ||
| .to( "#moduleMapping#.models.plugins.EmojiLogCommitParser" ); | ||
| binder.map( "DefaultCommitFilterer@commandbox-semantic-release" ) | ||
| .to( "#moduleMapping#.models.plugins.DefaultCommitFilterer" ); | ||
| binder.map( "DefaultCommitAnalyzer@commandbox-semantic-release" ) | ||
| .to( "#moduleMapping#.models.plugins.DefaultCommitAnalyzer" ); | ||
| binder.map( "DefaultCommitFilterer@commandbox-semantic-release" ) | ||
| .to( "#moduleMapping#.models.plugins.DefaultCommitFilterer" ); | ||
| binder.map( "EmojiLogCommitAnalyzer@commandbox-semantic-release" ) | ||
| .to( "#moduleMapping#.models.plugins.EmojiLogCommitAnalyzer" ); | ||
| binder.map( "NullReleaseVerifier@commandbox-semantic-release" ) | ||
| .to( "#moduleMapping#.models.plugins.NullReleaseVerifier" ); | ||
| binder.map( "GitHubMarkdownNotesGenerator@commandbox-semantic-release" ) | ||
| .to( "#moduleMapping#.models.plugins.GitHubMarkdownNotesGenerator" ); | ||
| binder.map( "EmojiLogCommitParser@commandbox-semantic-release" ) | ||
| .to( "#moduleMapping#.models.plugins.EmojiLogCommitParser" ); | ||
| binder.map( "FileAppendChangelogUpdater@commandbox-semantic-release" ) | ||
| .to( "#moduleMapping#.models.plugins.FileAppendChangelogUpdater" ); | ||
| binder.map( "NullArtifactsCommitter@commandbox-semantic-release" ) | ||
| .to( "#moduleMapping#.models.plugins.NullArtifactsCommitter" ); | ||
| binder.map( "GitHubArtifactsCommitter@commandbox-semantic-release" ) | ||
| .to( "#moduleMapping#.models.plugins.GitHubArtifactsCommitter" ); | ||
| binder.map( "ForgeBoxReleaseFetcher@commandbox-semantic-release" ) | ||
| .to( "#moduleMapping#.models.plugins.ForgeBoxReleaseFetcher" ); | ||
| binder.map( "ForgeBoxReleasePublisher@commandbox-semantic-release" ) | ||
| .to( "#moduleMapping#.models.plugins.ForgeBoxReleasePublisher" ); | ||
| binder.map( "GitHubActionsConditionsVerifier@commandbox-semantic-release" ) | ||
| .to( "#moduleMapping#.models.plugins.GitHubActionsConditionsVerifier" ); | ||
| binder.map( "GitHubArtifactsCommitter@commandbox-semantic-release" ) | ||
| .to( "#moduleMapping#.models.plugins.GitHubArtifactsCommitter" ); | ||
| binder.map( "GitHubMarkdownNotesGenerator@commandbox-semantic-release" ). | ||
| to( "#moduleMapping#.models.plugins.GitHubMarkdownNotesGenerator" ); | ||
| binder.map( "GitHubReleasePublicizer@commandbox-semantic-release" ) | ||
| .to( "#moduleMapping#.models.plugins.GitHubReleasePublicizer" ); | ||
|
|
||
| binder.map( "GitLabConditionsVerifier@commandbox-semantic-release" ) | ||
| .to( "#moduleMapping#.models.plugins.GitLabConditionsVerifier" ); | ||
| binder.map( "GitLabArtifactsCommitter@commandbox-semantic-release" ) | ||
| .to( "#moduleMapping#.models.plugins.GitLabArtifactsCommitter" ); | ||
| binder.map( "GitLabConditionsVerifier@commandbox-semantic-release" ) | ||
| .to( "#moduleMapping#.models.plugins.GitLabConditionsVerifier" ); | ||
| binder.map( "GitLabReleaseFetcher@commandbox-semantic-release" ) | ||
| .to( "#moduleMapping#.models.plugins.GitLabReleaseFetcher" ); | ||
| binder.map( "GitLabReleasePublicizer@commandbox-semantic-release" ) | ||
| .to( "#moduleMapping#.models.plugins.GitLabReleasePublicizer" ); | ||
| binder.map( "JGitCommitsRetriever@commandbox-semantic-release" ) | ||
| .to( "#moduleMapping#.models.plugins.JGitCommitsRetriever" ); | ||
| binder.map( "NullArtifactsCommitter@commandbox-semantic-release" ) | ||
| .to( "#moduleMapping#.models.plugins.NullArtifactsCommitter" ); | ||
| binder.map( "NullChangelogUpdater@commandbox-semantic-release" ) | ||
| .to( "#moduleMapping#.models.plugins.NullChangelogUpdater" ); | ||
| binder.map( "NullConditionsVerifier@commandbox-semantic-release" ) | ||
| .to( "#moduleMapping#.models.plugins.NullConditionsVerifier" ); | ||
| binder.map( "NullNotesGenerator@commandbox-semantic-release" ) | ||
| .to( "#moduleMapping#.models.plugins.NullNotesGenerator" ); | ||
| binder.map( "NullReleasePublisher@commandbox-semantic-release" ) | ||
| .to( "#moduleMapping#.models.plugins.NullReleasePublisher" ); | ||
| binder.map( "NullReleaseVerifier@commandbox-semantic-release" ) | ||
| .to( "#moduleMapping#.models.plugins.NullReleaseVerifier" ); | ||
| binder.map( "TravisConditionsVerifier@commandbox-semantic-release" ) | ||
| .to( "#moduleMapping#.models.plugins.TravisConditionsVerifier" ); | ||
| } | ||
|
|
||
| function onLoad() { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| component implements="interfaces.ChangelogUpdater" { | ||
|
|
||
| property name="print" inject="PrintBuffer"; | ||
|
|
||
| /** | ||
| * Updates the current changelog with the new notes. | ||
| * | ||
| * @notes The notes for the new release. | ||
| * @dryRun Flag to indicate a dry run of the release. | ||
| * @verbose Flag to indicate printing out extra information. | ||
| */ | ||
| public void function run( | ||
| required string notes, | ||
| required string nextVersion, | ||
| boolean dryRun = false, | ||
| boolean verbose = false | ||
| ) { | ||
|
|
||
| if ( verbose ) { | ||
| print.line() | ||
| .indented() | ||
| .boldBlackOnYellowLine( " NULL CHANGELOG UPDATER - NO CHANGELOG WRITTEN " ) | ||
| .line() | ||
| .toConsole(); | ||
| } | ||
|
|
||
| } | ||
|
|
||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| component implements="interfaces.NotesGenerator" { | ||
|
|
||
| /** | ||
| * Generates markdown notes for the new release on GitHub | ||
| * | ||
| * @lastVersion The last version of the package. | ||
| * @nextVersion The next version of the package. | ||
| * @commits An array of commits between the two versions. | ||
| * @type The type of the next release: major, minor, or patch. | ||
| * @repositoryUrl The url of the remote repository. | ||
| * @dryRun Flag to indicate a dry run of the release. | ||
| * @verbose Flag to indicate printing out extra information. | ||
| * | ||
| * @return A string containing the new notes for the release. | ||
| */ | ||
| public string function run( | ||
| required string lastVersion, | ||
| required string nextVersion, | ||
| required array commits, | ||
| required string type, | ||
| required string repositoryUrl, | ||
| boolean dryRun = false, | ||
| boolean verbose = true | ||
| ) { | ||
| return ""; | ||
| } | ||
|
|
||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the new
preReleaseIDandbuildID, how does it generate release versions? I don't want my release versions to look like5.1.0+0. (I don't want abuildIDat all.)As long as the
buildIDis completely optional, this should be good.