Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
npm testentry and a concise contributor guide.Description
testscript inpackage.jsonthat delegates to the repo validation aggregate by runningnpm run validate, and includedCONTRIBUTING.mdin the publishedfileslist.CONTRIBUTING.mdwith focused contributor workflow, PR expectations, commit convention, required pre-merge validation commands, and guidance when changing schemas/examples/docs.assertNoDuplicateObjectKeysimplementations and switchingscripts/validate-all.mjsandscripts/validate-examples.mjsto useloadJsonStrictfromscripts/load-json-strict.mjs.tsconfig.jsonand updated docs to clearly state there is no current-line TypeScript compile target while labeling legacyv1.0.0TS examples as compatibility artifacts.@commandlayer/commercial/schemas/v1.1.0/index.json, madeREADME.mdthe canonical validation command surface, reduced duplicated command blocks acrossINTEGRATOR.md,ONBOARDING.md,SECURITY.md, andSPEC.md, and added brief schema-browsing guidance for the flat self-contained architecture.Files changed:
package.json,CONTRIBUTING.md(new),README.md,INTEGRATOR.md,ONBOARDING.md,SECURITY.md,SPEC.md,scripts/validate-all.mjs,scripts/validate-examples.mjs, and deletion oftsconfig.json.Exact decisions made:
npm testmaps tonpm run validate; strict JSON loading is centralized toloadJsonStrict; duplicate-key helper code was removed from validation scripts; docs use explicit JSON path imports by default;README.mdis the canonical command list;v1.0.0remains a retained legacy line and is documented as not receiving the same automated validation guarantees.Intentionally left unchanged: repository schema contracts and semantics were not modified;
scripts/load-json-strict.mjsitself was not changed since it already implements the canonical strict loader; no CI coverage forv1.0.0was added because the repo policy treats it as retained legacy rather than an actively supported current line.Testing
npm testwhich executes the full validation aggregate and it completed successfully.npm run validate:schemas,npm run validate:examples,npm run validate:integrity) and each stage succeeded.sha256sum -c checksums.txtand all checksum entries passed.Codex Task