Add @types/node, update Python project URLs, and add CHANGELOG#12
Merged
Add @types/node, update Python project URLs, and add CHANGELOG#12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
CHANGELOG.mdand link it from the repo README to improve release optics.Description
@types/nodeunderdevDependenciesintypescript-sdk/package.jsonas"@types/node": "^20.17.0"to pin Node typings for the TypeScript SDK.python-sdk/pyproject.tomlwith repository-based links forHomepage,Repository,Documentation, andChangelog.CHANGELOG.mdat the repo root with a minimal1.1.0entry and linked it fromREADME.md.Testing
node_modules/package-lock.jsonand runningnpm install,npm run typecheck,npm run build, andnpm test, butnpm installfailed due to the environment's package proxy returning403 Forbidden, so the full TS validation could not be completed.@types/nodedeclaration by readingtypescript-sdk/package.jsonand confirmingdevDependencies['@types/node']is present.python -m buildandtwine check dist/*, butpython -m buildfailed because thebuildtooling is not installed andpip install build twineis blocked by the same proxy403 Forbidden, so artifact checks could not be run.python-sdk/pyproject.toml,README.md, and the newly createdCHANGELOG.md, confirming the requested URLs and README link are present.Codex Task