Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
@types/nodeunderdevDependenciesintypescript-sdk/package.jsonto declare Node typings explicitly.python-sdk/pyproject.toml[project.urls]block with concreteHomepage,Repository,Documentation, andChangelogURLs pointing at the repo.CHANGELOG.mdwith a concise1.1.0entry documenting the canonical receipt model and packaging/typing changes.CHANGELOG.mdfrom the top-levelREADME.mdso the changelog is discoverable from the main docs.Testing
rm -rf node_modules package-lock.json && npm install && npm run typecheck && npm run build && npm test, butnpm installfailed with a403 Forbiddenwhen fetching@types/node, preventingtypecheck,build, andtestfrom completing.tscafter the failed install produced missing Node type errors because local dev dependencies were unavailable.python -m buildandtwine check dist/*, but the environment lacked thebuildtool andpipinstalls ofbuild/twinewere blocked by a proxy403, so packaging checks could not run.pyproject.tomlURL block is present and thatCHANGELOG.mdis created and linked fromREADME.md(non-network file checks succeeded).Codex Task