Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
test_vectorsand that recomputed hashes, signer resolution, and pass/fail outcomes match; key assets aretest_vectors/parity_manifest.json,scripts/parity-check.mjs,scripts/parity-ts-report.mjs, andpython-sdk/tests/parity_report.py.parity-check(.github/workflows/parity-check.yml) which installs/builds the TypeScript SDK, installs Python dev deps, and executes the root parity check so mismatches cause the job to fail.python-sdk/tests/test_public_api.pythat asserts importable symbols,create_client()behavior, presence and callability of verb methods, response envelope shape,verify_receiptcontract, and a fast mocked end-to-end vector-backed flow.README.mdand lightweight guide stubs (CONTRIBUTING.md,MAINTAINER_GUIDE.md,RELEASE_GUIDE.md,CHANGELOG.md, andtest_vectors/README.md) to make navigation immediate and explicit.Testing
npm install/npm run build/npm testintypescript-sdk, and all unit and runtime tests passed locally (TS build and test suite succeeded).PYTHONPATH=. python -m pytestand the full Python test suite passed (pytestsucceeded), butpip install -e '.[dev]'andpython -m buildfailed in this environment due to missing build-time dependencies (network/proxy prevented fetchingsetuptools/build), so packaging steps failed here but are covered by the CI job which installs deps in a clean runner.node scripts/parity-check.mjswhich invoked bothscripts/parity-ts-report.mjsandpython-sdk/tests/parity_report.py; the reports were normalized and compared and the parity check passed locally, printing per-vector PASS/FAIL lines and exiting non-zero on mismatch (the workflow is configured to run this check in CI).Codex Task