DEVX-640-helper-method-from-Coco-product-to-import-API-product #1000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1000 +/- ##
==========================================
+ Coverage 9.51% 9.66% +0.14%
- Complexity 2016 2059 +43
==========================================
Files 7717 7719 +2
Lines 75665 75932 +267
Branches 302 347 +45
==========================================
+ Hits 7202 7341 +139
- Misses 68286 68402 +116
- Partials 177 189 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
…-product-to-import-API-product' into DEVX-640-helper-method-from-Coco-product-to-import-API-product
…import-API-product
…-product-to-import-API-product' into DEVX-640-helper-method-from-Coco-product-to-import-API-product
…-product-to-import-API-product' into DEVX-640-helper-method-from-Coco-product-to-import-API-product
…-product-to-import-API-product' into DEVX-640-helper-method-from-Coco-product-to-import-API-product
jenschude
reviewed
Oct 28, 2025
Comment on lines
27
to
30
| public final class ProductUtil { | ||
| private static KeyResolverService keyResolverService = new ExpandObjResolverService(); | ||
|
|
||
| public static ProductDraftImport toProductDraftImport(ProductProjection product) { |
Contributor
There was a problem hiding this comment.
Suggested change
| public final class ProductUtil { | |
| private static KeyResolverService keyResolverService = new ExpandObjResolverService(); | |
| public static ProductDraftImport toProductDraftImport(ProductProjection product) { | |
| public class ProductUtil { | |
| private final KeyResolverService keyResolverService; | |
| public ProductUtil() { | |
| keyResolverService = new ExpandObjResolverService(); | |
| } | |
| public ProductUtil(final KeyResolverService resolverService) { | |
| keyResolverService = resolverService; | |
| } | |
| public ProductDraftImport toProductDraftImport(ProductProjection product) { |
It should be possible to inject the resolver service. You will have to rewrite some method signatures and remove the static keyword
…-product-to-import-API-product' into DEVX-640-helper-method-from-Coco-product-to-import-API-product # Conflicts: # commercetools/commercetools-importapi-utils/src/main/java/com/commercetools/sdk/ProductUtil.java
ShipilA
deleted the
DEVX-640-helper-method-from-Coco-product-to-import-API-product
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://commercetools.atlassian.net/jira/software/c/projects/DEVX/boards/1507?selectedIssue=DEVX-640
Added the Util class and test