Skip to content

Fix product Mixin Product level attributes #971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 21, 2025
Merged

Fix product Mixin Product level attributes #971

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2899aac
Fix product Mixin Product level attributes
ShipilA Aug 21, 2025
ad7842f
Update commercetools/commercetools-sdk-java-api/src/main/java/com/com…
jenschude Aug 21, 2025
a36f2aa
revert
jenschude Aug 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...ools-sdk-java-api/src/main/java/com/commercetools/api/models/product/ProductDataLike.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,4 +109,7 @@ default Optional<ProductVariant> findVariantBySku(final String sku) {

@Nullable
CategoryOrderHints getCategoryOrderHints();

@Nullable
List<Attribute> getAttributes();
}
4 changes: 4 additions & 0 deletions ...cetools-sdk-java-api/src/main/java/com/commercetools/api/models/product/ProductMixin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@

package com.commercetools.api.models.product;

import java.util.Collections;
import java.util.Optional;
import java.util.stream.Collectors;

Expand Down Expand Up @@ -55,6 +56,9 @@ public static ProductProjection toProjection(final Product template,
.state(StateReference.deepCopy(template.getState()))
.reviewRatingStatistics(ReviewRatingStatistics.deepCopy(template.getReviewRatingStatistics()))
.priceMode(template.getPriceMode())
.attributes(Optional.ofNullable(productDataLike.getAttributes())
.map(a -> a.stream().map(Attribute::deepCopy).collect(Collectors.toList()))
.orElse(Collections.emptyList()))
.build();
}
}