Skip to content

SUPPORT-34507: update SDK version for latest product-draft model #1227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kafis merged 1 commit into from
Aug 26, 2025
Merged

SUPPORT-34507: update SDK version for latest product-draft model #1227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ plugins {
}

ext{
commercetoolsJavaSdkV2Version = '18.0.0'
commercetoolsJavaSdkV2Version = '19.3.0'
mockitoJunitJupiterVersion = '5.19.0'
jupiterApiVersion = '5.13.4'
jupiterPlatformVersion = '1.13.4'
Expand Down
11 changes: 6 additions & 5 deletions src/test/java/com/commercetools/sync/products/utils/ProductSyncUtilsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,11 +58,7 @@
import com.commercetools.api.models.product.ProductVariantDraftBuilder;
import com.commercetools.api.models.product.SearchKeywordBuilder;
import com.commercetools.api.models.product.SearchKeywordsBuilder;
import com.commercetools.api.models.product_type.AttributeConstraintEnum;
import com.commercetools.api.models.product_type.AttributeDefinitionBuilder;
import com.commercetools.api.models.product_type.AttributeTypeBuilder;
import com.commercetools.api.models.product_type.ProductTypeResourceIdentifierBuilder;
import com.commercetools.api.models.product_type.TextInputHint;
import com.commercetools.api.models.product_type.*;
import com.commercetools.sync.commons.utils.TestUtils;
import com.commercetools.sync.products.AttributeMetaData;
import com.commercetools.sync.products.ProductSyncMockUtils;
Expand Down Expand Up @@ -463,6 +459,7 @@ void buildActions_FromDraftsWithSameForAllAttribute_ShouldBuildUpdateActions() {
.name("brandName")
.attributeConstraint(AttributeConstraintEnum.SAME_FOR_ALL)
.type(AttributeTypeBuilder::textBuilder)
.level(AttributeLevelEnum.VARIANT)
.label(ofEnglish("brandName"))
.isRequired(false)
.inputHint(TextInputHint.SINGLE_LINE)
Expand Down Expand Up @@ -539,6 +536,7 @@ void buildActions_FromDraftsWithDifferentAttributes_ShouldBuildUpdateActions() {
.name("brandName")
.attributeConstraint(AttributeConstraintEnum.NONE)
.type(AttributeTypeBuilder::textBuilder)
.level(AttributeLevelEnum.VARIANT)
.label(ofEnglish("brandName"))
.isRequired(false)
.inputHint(TextInputHint.SINGLE_LINE)
Expand All @@ -550,6 +548,7 @@ void buildActions_FromDraftsWithDifferentAttributes_ShouldBuildUpdateActions() {
.name("orderLimit")
.attributeConstraint(AttributeConstraintEnum.NONE)
.type(AttributeTypeBuilder::textBuilder)
.level(AttributeLevelEnum.VARIANT)
.label(ofEnglish("orderLimit"))
.isRequired(false)
.inputHint(TextInputHint.SINGLE_LINE)
Expand All @@ -561,6 +560,7 @@ void buildActions_FromDraftsWithDifferentAttributes_ShouldBuildUpdateActions() {
.name("priceInfo")
.attributeConstraint(AttributeConstraintEnum.NONE)
.type(AttributeTypeBuilder::textBuilder)
.level(AttributeLevelEnum.VARIANT)
.label(ofEnglish("priceInfo"))
.isRequired(false)
.inputHint(TextInputHint.SINGLE_LINE)
Expand All @@ -572,6 +572,7 @@ void buildActions_FromDraftsWithDifferentAttributes_ShouldBuildUpdateActions() {
.name("size")
.attributeConstraint(AttributeConstraintEnum.NONE)
.type(AttributeTypeBuilder::textBuilder)
.level(AttributeLevelEnum.VARIANT)
.label(ofEnglish("size"))
.isRequired(false)
.inputHint(TextInputHint.SINGLE_LINE)
Expand Down
10 changes: 5 additions & 5 deletions src/test/java/com/commercetools/sync/products/utils/ProductUpdateActionUtilsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,7 @@
import com.commercetools.api.models.product.ProductVariant;
import com.commercetools.api.models.product.ProductVariantDraft;
import com.commercetools.api.models.product.ProductVariantDraftBuilder;
import com.commercetools.api.models.product_type.AttributeConstraintEnum;
import com.commercetools.api.models.product_type.AttributeDefinitionBuilder;
import com.commercetools.api.models.product_type.AttributeTypeBuilder;
import com.commercetools.api.models.product_type.ProductTypeResourceIdentifier;
import com.commercetools.api.models.product_type.TextInputHint;
import com.commercetools.api.models.product_type.*;
import com.commercetools.sync.products.AttributeMetaData;
import com.commercetools.sync.products.ProductSyncMockUtils;
import com.commercetools.sync.products.ProductSyncOptions;
Expand Down Expand Up @@ -91,6 +87,7 @@ static void beforeAll() {
.label(LocalizedString.ofEnglish("priceInfo"))
.attributeConstraint(AttributeConstraintEnum.NONE)
.type(AttributeTypeBuilder::textBuilder)
.level(AttributeLevelEnum.VARIANT)
.isRequired(false)
.isSearchable(true)
.inputHint(TextInputHint.SINGLE_LINE)
Expand All @@ -103,6 +100,7 @@ static void beforeAll() {
.label(LocalizedString.ofEnglish("size"))
.attributeConstraint(AttributeConstraintEnum.NONE)
.type(AttributeTypeBuilder::textBuilder)
.level(AttributeLevelEnum.VARIANT)
.isRequired(false)
.isSearchable(true)
.inputHint(TextInputHint.SINGLE_LINE)
Expand Down Expand Up @@ -245,6 +243,7 @@ void buildVariantsUpdateActions_updateVariantsWithSameForAll() {
.label(LocalizedString.ofEnglish("priceInfo"))
.attributeConstraint(AttributeConstraintEnum.SAME_FOR_ALL)
.type(AttributeTypeBuilder::textBuilder)
.level(AttributeLevelEnum.VARIANT)
.isRequired(false)
.isSearchable(true)
.inputHint(TextInputHint.SINGLE_LINE)
Expand All @@ -256,6 +255,7 @@ void buildVariantsUpdateActions_updateVariantsWithSameForAll() {
.label(LocalizedString.ofEnglish("size"))
.attributeConstraint(AttributeConstraintEnum.NONE)
.type(AttributeTypeBuilder::textBuilder)
.level(AttributeLevelEnum.VARIANT)
.isRequired(false)
.isSearchable(true)
.inputHint(TextInputHint.SINGLE_LINE)
Expand Down
10 changes: 5 additions & 5 deletions ...uctvariantupdateactionutils/attributes/BuildProductVariantAttributeUpdateActionsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,7 @@
import com.commercetools.api.models.product.ProductSetAttributeActionBuilder;
import com.commercetools.api.models.product.ProductSetAttributeInAllVariantsActionBuilder;
import com.commercetools.api.models.product.ProductUpdateAction;
import com.commercetools.api.models.product_type.AttributeConstraintEnum;
import com.commercetools.api.models.product_type.AttributeDefinition;
import com.commercetools.api.models.product_type.AttributeDefinitionBuilder;
import com.commercetools.api.models.product_type.AttributeTextTypeBuilder;
import com.commercetools.api.models.product_type.TextInputHint;
import com.commercetools.api.models.product_type.*;
import com.commercetools.sync.commons.exceptions.BuildUpdateActionException;
import com.commercetools.sync.products.AttributeMetaData;
import com.commercetools.sync.products.utils.ProductVariantAttributeUpdateActionUtils;
Expand All @@ -39,6 +35,7 @@ void withNullOldAndNonNullNew_ShouldBuildSetAction() throws BuildUpdateActionExc
.name(newAttribute.getName())
.label(ofEnglish("foo"))
.type(AttributeTextTypeBuilder.of().build())
.level(AttributeLevelEnum.VARIANT)
.attributeConstraint(AttributeConstraintEnum.NONE)
.inputHint(TextInputHint.SINGLE_LINE)
.isSearchable(true)
Expand Down Expand Up @@ -76,6 +73,7 @@ void withNullOldAndNonNullNew_WithSameForAllAttribute_ShouldBuildSetAllAction()
.name(newAttribute.getName())
.label(ofEnglish("foo"))
.type(AttributeTextTypeBuilder.of().build())
.level(AttributeLevelEnum.VARIANT)
.attributeConstraint(AttributeConstraintEnum.SAME_FOR_ALL)
.inputHint(TextInputHint.SINGLE_LINE)
.isSearchable(true)
Expand Down Expand Up @@ -136,6 +134,7 @@ void withDifferentValues_ShouldBuildSetAction() throws BuildUpdateActionExceptio
.name(newAttribute.getName())
.label(ofEnglish("foo"))
.type(AttributeTextTypeBuilder.of().build())
.level(AttributeLevelEnum.VARIANT)
.attributeConstraint(AttributeConstraintEnum.NONE)
.inputHint(TextInputHint.SINGLE_LINE)
.isSearchable(true)
Expand Down Expand Up @@ -172,6 +171,7 @@ void withSameValues_ShouldNotBuildAction() throws BuildUpdateActionException {
.name(newAttribute.getName())
.label(ofEnglish("foo"))
.type(AttributeTextTypeBuilder.of().build())
.level(AttributeLevelEnum.VARIANT)
.attributeConstraint(AttributeConstraintEnum.SAME_FOR_ALL)
.inputHint(TextInputHint.SINGLE_LINE)
.isSearchable(true)
Expand Down
Loading
Loading