-
Notifications
You must be signed in to change notification settings - Fork 29
CRAFT-1995: update @sentry to v8 #3904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 2fb6ff3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3904 +/- ##
==========================================
+ Coverage 75.04% 75.06% +0.02%
==========================================
Files 259 260 +1
Lines 6355 6361 +6
Branches 1978 2009 +31
==========================================
+ Hits 4769 4775 +6
Misses 1565 1565
Partials 21 21
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
tylermorrisford
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
relatively minor nit, otherwise this looks nice pending checks and a good build ❤️
|
[preview_deployment] |
|
Release workflow failed ❌\nSee details: Workflow Run |
|
[preview_deployment] |
|
Release workflow succeeded ✅\nSee details: Workflow Run |
@tylermorrisford good call. Updated the comment a bit to make it clearer, and noted it in the pr description as well. TL;DR - this was purely for type checking. Sentry v8's |
69c0631 to
da59af9
Compare
da59af9 to
998a54a
Compare
Existing
@commercetools-frontend/sentrypackage is not compatible with react 19 and causing peer dependency conflicts. Official React 19 support was added in Sentry v8.References:
https://commercetools.atlassian.net/browse/CRAFT-1995
#3879
Note that this PR intentionally keeps deprecated Sentry v8 types (
Event, Extra, Extras) for now to minimize breaking changes.1.) Upgraded the following Sentry packages from v7.120.4 → v8.55.0 and resolved breaking changes:
@sentry/react, @sentry/browser, @sentry/typesbeforeSendcallback:Issues:
Resolutions:
SentryErrorEventto avoid name collision with DOM typesSentryErrorEvent(safe since beforeSend only receives error events)4.) Added a few tests to ensures the v8 API migration (configureScope → getCurrentScope()) works correctly.
Testing notes
dependencies: