Skip to content

[no touchie, please] CRAFT-2200- feat(chromatic): add to CI - got a day left to experiment. let's do this!#1232

Closed
valoriecarli wants to merge 9 commits intomainfrom
CRAFT-2200-chromatic-ci
Closed

[no touchie, please] CRAFT-2200- feat(chromatic): add to CI - got a day left to experiment. let's do this!#1232
valoriecarli wants to merge 9 commits intomainfrom
CRAFT-2200-chromatic-ci

Conversation

@valoriecarli
Copy link
Copy Markdown
Collaborator

@valoriecarli valoriecarli commented Mar 11, 2026

1.) configs only - open pr - expect chromatic build to skip. Result? ✅ ae0e4e0

  • The paths filter at the event level prevents the workflow from being queued entirely. It doesn't appear in the Actions tab as skipped at all.

2.) +4 scoped files to kick off Chromatic - draft pr - expect chromatic build to skip. Result? ✅ b814baa

3.) toggled draft to open - expect chromatic to automagically run. Result? ✅ ( no associated commit)

4.) added non-ui file change - expect chromatic not to run, but my feels tell me it will. Result? 🔴 577e0eb
**As is GH evaluates the full PR diff — not just the latest push. Since this PR has UI files in its history, every push will trigger Chromatic via the synchronize event.

5.) relates to ☝🏻. added tj-actions/changed-files to detect ONLY commits (on same branch) with ui-changes.- open pr - expect Chromatic to skip. Result? 3d5a437 & 10a1871.. eventually ✅

6.) added comment in ui file - open pr - expect Chromatic to run. Results? ✅ e436fc2

@valoriecarli valoriecarli self-assigned this Mar 11, 2026
@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 11, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nimbus-documentation Ready Ready Preview, Comment Mar 11, 2026 4:40pm
nimbus-storybook Ready Ready Preview, Comment Mar 11, 2026 4:40pm

Request Review

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 11, 2026

⚠️ No Changeset found

Latest commit: e436fc2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@valoriecarli valoriecarli added the WIP Work is ongoing, suggestions welcome label Mar 11, 2026
@valoriecarli valoriecarli changed the title feat(chromatic): add to CI - expecting no chromatic run feat(chromatic): add to CI - got a day left to experiment. let's do this! Mar 11, 2026
@valoriecarli valoriecarli changed the title feat(chromatic): add to CI - got a day left to experiment. let's do this! CRAFT-2200- feat(chromatic): add to CI - got a day left to experiment. let's do this! Mar 11, 2026
@valoriecarli valoriecarli marked this pull request as draft March 11, 2026 15:37
@valoriecarli valoriecarli changed the title CRAFT-2200- feat(chromatic): add to CI - got a day left to experiment. let's do this! [no touchie, please] CRAFT-2200- feat(chromatic): add to CI - got a day left to experiment. let's do this! Mar 11, 2026
@valoriecarli valoriecarli marked this pull request as ready for review March 11, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WIP Work is ongoing, suggestions welcome

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant