[no touchie, please] CRAFT-2200- feat(chromatic): add to CI - got a day left to experiment. let's do this!#1232
Closed
valoriecarli wants to merge 9 commits intomainfrom
Closed
[no touchie, please] CRAFT-2200- feat(chromatic): add to CI - got a day left to experiment. let's do this!#1232valoriecarli wants to merge 9 commits intomainfrom
valoriecarli wants to merge 9 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.) configs only - open pr - expect chromatic build to skip. Result? ✅ ae0e4e0
2.) +4 scoped files to kick off Chromatic - draft pr - expect chromatic build to skip. Result? ✅ b814baa
3.) toggled draft to open - expect chromatic to automagically run. Result? ✅ ( no associated commit)
4.) added non-ui file change - expect chromatic not to run, but my feels tell me it will. Result? 🔴 577e0eb
**As is GH evaluates the full PR diff — not just the latest push. Since this PR has UI files in its history, every push will trigger Chromatic via the synchronize event.
5.) relates to ☝🏻. added
tj-actions/changed-filesto detect ONLY commits (on same branch) with ui-changes.- open pr - expect Chromatic to skip. Result? 3d5a437 & 10a1871.. eventually ✅6.) added comment in ui file - open pr - expect Chromatic to run. Results? ✅ e436fc2